Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 2878923003: Emit UMAs for private memory footprint. (Closed)

Created:
3 years, 7 months ago by erikchen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Emit UMAs for private memory footprint. This CL emits UMA metrics for the newly added field private memory footprint that the memory instrumentation interface provides. BUG=703184, 721434 TBR=rkaplow@chromium.org

Patch Set 1 #

Patch Set 2 : remove todo #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M chrome/browser/metrics/process_memory_metrics_emitter.cc View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (17 generated)
Primiano Tucci (use gerrit)
lgtm
3 years, 7 months ago (2017-05-12 21:14:11 UTC) #5
erikchen
TBR-ing rkaplow for a tiny change on top of https://codereview.chromium.org/2876693002/, which they already reviewed.
3 years, 7 months ago (2017-05-12 21:15:58 UTC) #8
erikchen
3 years, 7 months ago (2017-05-15 17:49:35 UTC) #20
Message was sent while issue was closed.
closing issue as this is getting wrapped in
https://codereview.chromium.org/2883693002/

Powered by Google App Engine
This is Rietveld 408576698