Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2876733005:
memory-infra: Assemble dump results in service (Closed)
|
Created:
3 years, 7 months ago by erikchen Modified:
3 years, 7 months ago CC:
chromium-reviews, chrome-grc-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review) Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionmemory-infra: Assemble dump results in service
This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written
by hjd@. I fixed some issues and addressed some nits as well.
> Do two new things:
> 1) Compute private memory footprint in a platform specific way.
> 2) Match up OSMemDumps with the correct ChromeMemDump.
>
> Both of these require a bit more work, we need to get the correct
> PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS,
> improved on OSX and checked on Android.
BUG=703184, 721882
TBR=dcheng@chromium.org
Review-Url: https://codereview.chromium.org/2876733005
Cr-Commit-Position: refs/heads/master@{#471630}
Committed: https://chromium.googlesource.com/chromium/src/+/df95d5dffe9aa1d9969f097baf40552fa13eea3b
Patch Set 1 #Patch Set 2 : Many fixes, clean up. #Patch Set 3 : Clean up #
Dependent Patchsets: Messages
Total messages: 29 (19 generated)
Description was changed from ========== memory-infra: Assemble dump results in service This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written by hjd@. > Do two new things: > 1) Compute private memory footprint in a platform specific way. > 2) Match up OSMemDumps with the correct ChromeMemDump. > > Both of these require a bit more work, we need to get the correct > PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS, > improved on OSX and checked on Android. BUG=703184 TBR=dcheng@chromium.org ========== to ========== memory-infra: Assemble dump results in service This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written by hjd@. There are some nits that hjd@ will address when he gets back. > Do two new things: > 1) Compute private memory footprint in a platform specific way. > 2) Match up OSMemDumps with the correct ChromeMemDump. > > Both of these require a bit more work, we need to get the correct > PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS, > improved on OSX and checked on Android. BUG=703184, 721882 TBR=dcheng@chromium.org ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
primiano@chromium.org changed reviewers: + primiano@chromium.org
LGTM, none of the comments were really major (was about a dcheck). just file a bug against me linking the original hjd CL and i'll get to that next week.
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
LGTM (but in the future, I suggest uploading the original patch before rebase as PS1, to make any diffs easy to review. Thanks!)
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/12 21:02:38, dcheng wrote: > LGTM (but in the future, I suggest uploading the original patch before rebase as > PS1, to make any diffs easy to review. Thanks!) Yeah I asked the same but then realized that it wasn't that easy. Essentially this conflicted because hjd based his patch on my CL (ccrev.com/2871223002) before I addressed some comments (I think yours about nullptr).
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== memory-infra: Assemble dump results in service This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written by hjd@. There are some nits that hjd@ will address when he gets back. > Do two new things: > 1) Compute private memory footprint in a platform specific way. > 2) Match up OSMemDumps with the correct ChromeMemDump. > > Both of these require a bit more work, we need to get the correct > PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS, > improved on OSX and checked on Android. BUG=703184, 721882 TBR=dcheng@chromium.org ========== to ========== memory-infra: Assemble dump results in service This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written by hjd@. I fixed some issues and addressed some nits as well. > Do two new things: > 1) Compute private memory footprint in a platform specific way. > 2) Match up OSMemDumps with the correct ChromeMemDump. > > Both of these require a bit more work, we need to get the correct > PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS, > improved on OSX and checked on Android. BUG=703184, 721882 TBR=dcheng@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/12 21:40:30, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) re-lgtm
On 2017/05/12 21:40:30, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) re-lgtm
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2876733005/#ps20001 (title: "Many fixes, clean up.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from primiano@chromium.org, dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2876733005/#ps40001 (title: "Clean up")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494772918359850,
"parent_rev": "2d8b867dfc360643d87634931521e9c5a39594fc", "commit_rev":
"df95d5dffe9aa1d9969f097baf40552fa13eea3b"}
Message was sent while issue was closed.
Description was changed from ========== memory-infra: Assemble dump results in service This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written by hjd@. I fixed some issues and addressed some nits as well. > Do two new things: > 1) Compute private memory footprint in a platform specific way. > 2) Match up OSMemDumps with the correct ChromeMemDump. > > Both of these require a bit more work, we need to get the correct > PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS, > improved on OSX and checked on Android. BUG=703184, 721882 TBR=dcheng@chromium.org ========== to ========== memory-infra: Assemble dump results in service This CL is a rebase of https://codereview.chromium.org/2867213003/, a CL written by hjd@. I fixed some issues and addressed some nits as well. > Do two new things: > 1) Compute private memory footprint in a platform specific way. > 2) Match up OSMemDumps with the correct ChromeMemDump. > > Both of these require a bit more work, we need to get the correct > PIDs to do 2, 1 needs to be implemented on Windows & ChromeOS, > improved on OSX and checked on Android. BUG=703184, 721882 TBR=dcheng@chromium.org Review-Url: https://codereview.chromium.org/2876733005 Cr-Commit-Position: refs/heads/master@{#471630} Committed: https://chromium.googlesource.com/chromium/src/+/df95d5dffe9aa1d9969f097baf40... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/df95d5dffe9aa1d9969f097baf40... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
