Issue 2878733003: Check that a view exists before sending an accessibility event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2878733003: Check that a view exists before sending an accessibility event. (Closed)

Created:
3 years, 7 months ago by Zachary Kuznia

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Check that a view exists before sending an accessibility event. When handling bounds changes, the view can disappear before the AXWindowObjectWrapper gets the event. BUG=711483 TEST=Turn on accessibility, and press the overview button twice. Ensure it does not crash. Review-Url: https://codereview.chromium.org/2865923004 Cr-Original-Commit-Position: refs/heads/master@{#470249} Review-Url: https://codereview.chromium.org/2878733003 . Cr-Commit-Position: refs/branch-heads/3071@{#517} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ce6a3cb8deba99f5c5ce2fcf8b20e0260aa166a3

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	ui/views/accessibility/ax_window_obj_wrapper.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Zachary Kuznia

3 years, 7 months ago (2017-05-11 18:40:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ce6a3cb8deba99f5c5ce2fcf8b20e0260aa166a3.