Check that a view exists before sending an accessibility event.

Check that a view exists before sending an accessibility event.

When handling bounds changes, the view can disappear before the
AXWindowObjectWrapper gets the event.

BUG=711483
TEST=Turn on accessibility, and press the overview button twice.
Ensure it does not crash.

Review-Url: https://codereview.chromium.org/2865923004
Cr-Commit-Position: refs/heads/master@{#470249}
Committed: https://chromium.googlesource.com/chromium/src/+/546a3b42a3414c671362459b1519eaeefb43afc3

[zork, 2017-05-09 01:40:39]

zork@google.com changed reviewers:
+ dtseng@chromium.org, zork@google.com

[zork, 2017-05-09 01:40:40]

Please take a look.

[dmazzoni, 2017-05-09 05:17:57]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-05-09 05:17:57]

Thanks!

Looks like our changes overlapped - there were two separate bug
reports for the same issue.

Other: https://codereview.chromium.org/2869923003/

Let's try landing yours first; mine wasn't landing due to CQ
issues today.

[dmazzoni, 2017-05-09 05:18:05]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-05-09 05:18:05]

lgtm

[commit-bot: I haz the power, 2017-05-09 05:18:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 06:36:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494307085033480, "parent_rev":
"906aedf74008e1d36dfe1d48fdf236afb3cc5572", "commit_rev":
"546a3b42a3414c671362459b1519eaeefb43afc3"}

[commit-bot: I haz the power, 2017-05-09 06:36:59]

Description was changed from

==========
Check that a view exists before sending an accessibility event.

When handling bounds changes, the view can disappear before the
AXWindowObjectWrapper gets the event.

BUG=711483
TEST=Turn on accessibility, and press the overview button twice.
Ensure it does not crash.
==========

to

==========
Check that a view exists before sending an accessibility event.

When handling bounds changes, the view can disappear before the
AXWindowObjectWrapper gets the event.

BUG=711483
TEST=Turn on accessibility, and press the overview button twice.
Ensure it does not crash.

Review-Url: https://codereview.chromium.org/2865923004
Cr-Commit-Position: refs/heads/master@{#470249}
Committed:
https://chromium.googlesource.com/chromium/src/+/546a3b42a3414c671362459b1519...
==========

[commit-bot: I haz the power, 2017-05-09 06:37:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/546a3b42a3414c671362459b1519...

[varkha, 2017-05-09 07:00:57]

varkha@chromium.org changed reviewers:
+ varkha@chromium.org

[varkha, 2017-05-09 07:00:57]

A couple of nits.

https://codereview.chromium.org/2865923004/diff/1/ui/views/accessibility/ax_w...
File ui/views/accessibility/ax_window_obj_wrapper.cc (right):

https://codereview.chromium.org/2865923004/diff/1/ui/views/accessibility/ax_w...
ui/views/accessibility/ax_window_obj_wrapper.cc:107: views::View* view =
widget->GetRootView();
nit: s/view/root_view

https://codereview.chromium.org/2865923004/diff/1/ui/views/accessibility/ax_w...
ui/views/accessibility/ax_window_obj_wrapper.cc:108: if (view) {
nit: no {}