Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2878703003: [Chromedriver] Fix testAlertHandlingOnPageUnload. (Closed)

Created:
3 years, 7 months ago by gmanikpure
Modified:
3 years, 7 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, johnchen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Fix testAlertHandlingOnPageUnload. Include a user interaction in order to trigger beforeunload dialog. BUG=chromedriver:1803 Review-Url: https://codereview.chromium.org/2878703003 Cr-Commit-Position: refs/heads/master@{#471101} Committed: https://chromium.googlesource.com/chromium/src/+/aeb307193b0209d0c5ed24263ba5c673b062e7c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gmanikpure
Hi John, Could you please take a look whenever time permits? Thanks, Gauri
3 years, 7 months ago (2017-05-11 20:44:43 UTC) #2
stgao
lgtm
3 years, 7 months ago (2017-05-11 22:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878703003/1
3 years, 7 months ago (2017-05-11 22:27:31 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:50:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aeb307193b0209d0c5ed24263ba5...

Powered by Google App Engine
This is Rietveld 408576698