Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6028)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 2878703003: [Chromedriver] Fix testAlertHandlingOnPageUnload. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index 8919513c9a9595f0b22abd079471d7f4ca60e8db..18da3110613b10f9b22f7c0beb12f900acd9e57c 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -73,8 +73,6 @@ _NEGATIVE_FILTER = [
_VERSION_SPECIFIC_FILTER = {}
_VERSION_SPECIFIC_FILTER['HEAD'] = [
- # https://bugs.chromium.org/p/chromedriver/issues/detail?id=1803
- 'ChromeDriverTest.testAlertHandlingOnPageUnload',
]
_VERSION_SPECIFIC_FILTER['58'] = [
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1673
@@ -173,8 +171,6 @@ _ANDROID_NEGATIVE_FILTER['chromium'] = (
'ChromeDriverTest.testHoverOverElement',
# https://bugs.chromium.org/p/chromedriver/issues/detail?id=1478
'ChromeDriverTest.testShouldHandleNewWindowLoadingProperly',
- # https://bugs.chromium.org/p/chromedriver/issues/detail?id=1803
- 'ChromeDriverTest.testAlertHandlingOnPageUnload',
]
)
_ANDROID_NEGATIVE_FILTER['chromedriver_webview_shell'] = (
@@ -681,6 +677,7 @@ class ChromeDriverTest(ChromeDriverBaseTestWithWebServer):
def testAlertHandlingOnPageUnload(self):
self._driver.Load(self.GetHttpUrlForFile('/chromedriver/empty.html'))
self._driver.ExecuteScript('window.onbeforeunload=function(){return true}')
+ self._driver.FindElement('tag name', 'body').Click()
self._driver.GoBack()
self.assertTrue(self._driver.IsAlertOpen())
self._driver.HandleAlert(True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698