Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2878663002:
s/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html (Closed)
|
Created:
3 years, 7 months ago by horo Modified:
3 years, 7 months ago Reviewers:
tyoshino (SeeGerritForStatus) CC:
chromium-reviews, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptions/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html
This method name was renamed by https://codereview.chromium.org/2125523003.
BUG=624711
Review-Url: https://codereview.chromium.org/2878663002
Cr-Commit-Position: refs/heads/master@{#471115}
Committed: https://chromium.googlesource.com/chromium/src/+/bfb116be5c0899dc76e114b04d0954248a1380d2
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== s/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html BUG=624711 ========== to ========== s/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html This method name was renamed by https://codereview.chromium.org/2125523003. BUG=624711 ==========
horo@chromium.org changed reviewers: + tyoshino@chromium.org
tyoshino@ Pleas review this.
lgtm
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by horo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494540109321630, "parent_rev":
"a9ad5af20477742a1d287dfb9a7fbbfd63354082", "commit_rev":
"bfb116be5c0899dc76e114b04d0954248a1380d2"}
Message was sent while issue was closed.
Description was changed from ========== s/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html This method name was renamed by https://codereview.chromium.org/2125523003. BUG=624711 ========== to ========== s/setAlwaysAcceptCookies/setBlockThirdPartyCookies/ in third-party-cookie-relaxing-iframe.html This method name was renamed by https://codereview.chromium.org/2125523003. BUG=624711 Review-Url: https://codereview.chromium.org/2878663002 Cr-Commit-Position: refs/heads/master@{#471115} Committed: https://chromium.googlesource.com/chromium/src/+/bfb116be5c0899dc76e114b04d09... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bfb116be5c0899dc76e114b04d09... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
