Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy

Committed: https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97
Cr-Commit-Position: refs/heads/master@{#404620}

[tyoshino (SeeGerritForStatus), 2016-07-05 08:29:56]

Description was changed from

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
==========

to

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
==========

[tyoshino (SeeGerritForStatus), 2016-07-05 08:29:56]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2016-07-05 08:42:23]

LGTM as far as it goes, but it seems reasonable to change the name everywhere.
WDYT?

https://codereview.chromium.org/2125523003/diff/1/components/test_runner/test...
File components/test_runner/test_runner.cc (right):

https://codereview.chromium.org/2125523003/diff/1/components/test_runner/test...
components/test_runner/test_runner.cc:2611:
delegate_->SetAcceptAllCookies(!block);
Nit: Why not change the name up through the delegate as well?

[tyoshino (SeeGerritForStatus), 2016-07-05 14:12:42]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 14:12:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tyoshino (SeeGerritForStatus), 2016-07-05 14:17:13]

https://codereview.chromium.org/2125523003/diff/1/components/test_runner/test...
File components/test_runner/test_runner.cc (right):

https://codereview.chromium.org/2125523003/diff/1/components/test_runner/test...
components/test_runner/test_runner.cc:2611:
delegate_->SetAcceptAllCookies(!block);
On 2016/07/05 08:42:23, Mike West wrote:
> Nit: Why not change the name up through the delegate as well?

Done.

[tyoshino (SeeGerritForStatus), 2016-07-05 14:17:33]

On 2016/07/05 08:42:23, Mike West wrote:
> LGTM as far as it goes, but it seems reasonable to change the name everywhere.
> WDYT?

Yeah, ok.

[tyoshino (SeeGerritForStatus), 2016-07-05 14:18:00]

tyoshino@chromium.org changed reviewers:
+ rdsmith@chromium.org

[tyoshino (SeeGerritForStatus), 2016-07-05 14:18:01]

+rdsmith for some content directories

[tyoshino (SeeGerritForStatus), 2016-07-05 14:18:19]

Description was changed from

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
==========

to

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith
==========

[commit-bot: I haz the power, 2016-07-05 15:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 15:15:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike West, 2016-07-06 06:41:44]

mkwst@chromium.org changed reviewers:
+ clamy@chromium.org

[Mike West, 2016-07-06 06:41:44]

Thanks!

//content/shell LGTM, and the trivial changes to //content/browser LGTM too,
though I'm not an owner there. Perhaps clamy@ could stamp those during EMEA
daytime?

https://codereview.chromium.org/2125523003/diff/20001/content/shell/common/la...
File content/shell/common/layout_test/OWNERS (right):

https://codereview.chromium.org/2125523003/diff/20001/content/shell/common/la...
content/shell/common/layout_test/OWNERS:2: per-file
*_messages*.h=file://ipc/SECURITY_OWNERS
Nice catch. Would you mind putting this in `//content/shell/common` instead?

[tyoshino (SeeGerritForStatus), 2016-07-06 06:47:11]

https://codereview.chromium.org/2125523003/diff/20001/content/shell/common/la...
File content/shell/common/layout_test/OWNERS (right):

https://codereview.chromium.org/2125523003/diff/20001/content/shell/common/la...
content/shell/common/layout_test/OWNERS:2: per-file
*_messages*.h=file://ipc/SECURITY_OWNERS
On 2016/07/06 06:41:44, Mike West wrote:
> Nice catch. Would you mind putting this in `//content/shell/common` instead?

It seems then we need to change the pattern to catch sub-directories. Maybe it's
commonly placed in each leaf directory?

[tyoshino (SeeGerritForStatus), 2016-07-06 06:49:01]

Description was changed from

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith
==========

to

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy
==========

[clamy, 2016-07-07 12:28:56]

Thanks! content/ lgtm.

[Randy Smith (Not in Mondays), 2016-07-07 15:02:49]

I'm not sure you need me anymore, but content/browser/{download,loader} LGTM.

[tyoshino (SeeGerritForStatus), 2016-07-11 08:03:49]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-07-11 08:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
clamy@chromium.org, rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/2125523003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-11 08:04:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 09:15:22]

Description was changed from

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy
==========

to

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy
==========

[commit-bot: I haz the power, 2016-07-11 09:15:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-11 09:15:30]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 09:17:27]

Description was changed from

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy
==========

to

==========
Rename setAlwaysAcceptCookies to setBlockThirdPartyCookies

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy

Committed: https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97
Cr-Commit-Position: refs/heads/master@{#404620}
==========

[commit-bot: I haz the power, 2016-07-11 09:17:28]

Patchset 4 (id:??) landed as
https://crrev.com/a6b914673aa766600e9a6b76cad34563941d0e97
Cr-Commit-Position: refs/heads/master@{#404620}