Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

The CL is a replica of what was done for WebLocalFrameImpl, namely:

1. Introduce WebRemoteFrameBase that derives from WebRemoteFrame.
2. Make WebRemoteFrameImpl derive from WebRemoteFrameBase.
3. Make it possible to case from a RemoteFrame to WebRemoteFrameBase using 
ChromeClient.
4. Make WebRemoteFrameBase garbage collected and plumb through Trace calls.
5. Change WebFrame to use WebRemoteFrameBase instead of WebRemoteFrameImpl.
6. Make methods pure virtual in WebRemoteFrameBase and override in
WebRemoteFrameImpl.

BUG=712963
Review-Url: https://codereview.chromium.org/2878623002
Cr-Commit-Position: refs/heads/master@{#471226}
Committed: https://chromium.googlesource.com/chromium/src/+/411384cbbbe54a0a7f6e280705512f83c81f6540

[slangley, 2017-05-11 06:50:28]

Description was changed from

==========
Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

BUG=
==========

to

==========
Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

The CL is a replica of what was done for WebLocalFrameImpl, namely:

1. Introduce WebRemoteFrameBase that derives from WebRemoteFrame.
2. Make WebRemoteFrameImpl derive from WebRemoteFrameBase.
3. Make it possible to case from a RemoteFrame to WebRemoteFrameBase using 
ChromeClient.
4. Make WebRemoteFrameBase garbage collected and plumb through Trace calls.
5. Change WebFrame to use WebRemoteFrameBase instead of WebRemoteFrameImpl.
6. Make methods pure virtual in WebRemoteFrameBase and override in
WebRemoteFrameImpl.

BUG=712963
==========

[slangley, 2017-05-11 06:50:28]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-05-11 08:00:18]

LGTM

[slangley, 2017-05-11 08:07:21]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-11 08:07:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 09:08:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 09:08:55]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[slangley, 2017-05-11 12:03:57]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-11 12:03:58]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2878623002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-11 12:04:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 13:21:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 13:21:28]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[slangley, 2017-05-12 00:57:48]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-12 00:57:48]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2878623002/#ps40001
(title: "Fix windows linker errors.")

[commit-bot: I haz the power, 2017-05-12 00:58:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 01:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 01:56:17]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-05-12 04:20:04]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-12 04:20:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 05:20:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494562804696990,
"parent_rev": "0f82aa916a39eb944f388c1ae27435036cade852", "commit_rev":
"411384cbbbe54a0a7f6e280705512f83c81f6540"}

[commit-bot: I haz the power, 2017-05-12 05:20:38]

Description was changed from

==========
Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

The CL is a replica of what was done for WebLocalFrameImpl, namely:

1. Introduce WebRemoteFrameBase that derives from WebRemoteFrame.
2. Make WebRemoteFrameImpl derive from WebRemoteFrameBase.
3. Make it possible to case from a RemoteFrame to WebRemoteFrameBase using 
ChromeClient.
4. Make WebRemoteFrameBase garbage collected and plumb through Trace calls.
5. Change WebFrame to use WebRemoteFrameBase instead of WebRemoteFrameImpl.
6. Make methods pure virtual in WebRemoteFrameBase and override in
WebRemoteFrameImpl.

BUG=712963
==========

to

==========
Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl.

The CL is a replica of what was done for WebLocalFrameImpl, namely:

1. Introduce WebRemoteFrameBase that derives from WebRemoteFrame.
2. Make WebRemoteFrameImpl derive from WebRemoteFrameBase.
3. Make it possible to case from a RemoteFrame to WebRemoteFrameBase using 
ChromeClient.
4. Make WebRemoteFrameBase garbage collected and plumb through Trace calls.
5. Change WebFrame to use WebRemoteFrameBase instead of WebRemoteFrameImpl.
6. Make methods pure virtual in WebRemoteFrameBase and override in
WebRemoteFrameImpl.

BUG=712963

Review-Url: https://codereview.chromium.org/2878623002
Cr-Commit-Position: refs/heads/master@{#471226}
Committed:
https://chromium.googlesource.com/chromium/src/+/411384cbbbe54a0a7f6e28070551...
==========

[commit-bot: I haz the power, 2017-05-12 05:20:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/411384cbbbe54a0a7f6e28070551...

[sashab, 2017-05-15 01:59:47]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-05-15 01:59:48]

https://codereview.chromium.org/2878623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/WebRemoteFrameBase.h (right):

https://codereview.chromium.org/2878623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/WebRemoteFrameBase.h:3: // found in the
LICENSE file.#ifndef WebViewBase_h
Remove #ifndef WebViewBase_h