Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2878623002: Introduce WebRemoteFrameBase to break dependencies on WebRemoteFrameImpl. (Closed)
Patch Set: Fix windows linker errors. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 #include "web/ExternalDateTimeChooser.h" 116 #include "web/ExternalDateTimeChooser.h"
117 #include "web/ExternalPopupMenu.h" 117 #include "web/ExternalPopupMenu.h"
118 #include "web/IndexedDBClientImpl.h" 118 #include "web/IndexedDBClientImpl.h"
119 #include "web/LocalFileSystemClient.h" 119 #include "web/LocalFileSystemClient.h"
120 #include "web/NavigatorContentUtilsClientImpl.h" 120 #include "web/NavigatorContentUtilsClientImpl.h"
121 #include "web/PopupMenuImpl.h" 121 #include "web/PopupMenuImpl.h"
122 #include "web/WebFrameWidgetImpl.h" 122 #include "web/WebFrameWidgetImpl.h"
123 #include "web/WebInputEventConversion.h" 123 #include "web/WebInputEventConversion.h"
124 #include "web/WebLocalFrameImpl.h" 124 #include "web/WebLocalFrameImpl.h"
125 #include "web/WebPluginContainerImpl.h" 125 #include "web/WebPluginContainerImpl.h"
126 #include "web/WebRemoteFrameImpl.h"
126 #include "web/WebSettingsImpl.h" 127 #include "web/WebSettingsImpl.h"
127 128
128 namespace blink { 129 namespace blink {
129 130
130 namespace { 131 namespace {
131 132
132 const char* DialogTypeToString(ChromeClient::DialogType dialog_type) { 133 const char* DialogTypeToString(ChromeClient::DialogType dialog_type) {
133 switch (dialog_type) { 134 switch (dialog_type) {
134 case ChromeClient::kAlertDialog: 135 case ChromeClient::kAlertDialog:
135 return "alert"; 136 return "alert";
(...skipping 814 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 951
951 WebLayerTreeView* ChromeClientImpl::GetWebLayerTreeView(LocalFrame* frame) { 952 WebLayerTreeView* ChromeClientImpl::GetWebLayerTreeView(LocalFrame* frame) {
952 WebLocalFrameImpl* web_frame = WebLocalFrameImpl::FromFrame(frame); 953 WebLocalFrameImpl* web_frame = WebLocalFrameImpl::FromFrame(frame);
953 return web_frame->LocalRoot()->FrameWidget()->GetLayerTreeView(); 954 return web_frame->LocalRoot()->FrameWidget()->GetLayerTreeView();
954 } 955 }
955 956
956 WebLocalFrameBase* ChromeClientImpl::GetWebLocalFrameBase(LocalFrame* frame) { 957 WebLocalFrameBase* ChromeClientImpl::GetWebLocalFrameBase(LocalFrame* frame) {
957 return WebLocalFrameImpl::FromFrame(frame); 958 return WebLocalFrameImpl::FromFrame(frame);
958 } 959 }
959 960
961 WebRemoteFrameBase* ChromeClientImpl::GetWebRemoteFrameBase(
962 RemoteFrame& frame) {
963 return WebRemoteFrameImpl::FromFrame(frame);
964 }
965
960 void ChromeClientImpl::SetEventListenerProperties( 966 void ChromeClientImpl::SetEventListenerProperties(
961 LocalFrame* frame, 967 LocalFrame* frame,
962 WebEventListenerClass event_class, 968 WebEventListenerClass event_class,
963 WebEventListenerProperties properties) { 969 WebEventListenerProperties properties) {
964 // |frame| might be null if called via TreeScopeAdopter:: 970 // |frame| might be null if called via TreeScopeAdopter::
965 // moveNodeToNewDocument() and the new document has no frame attached. 971 // moveNodeToNewDocument() and the new document has no frame attached.
966 // Since a document without a frame cannot attach one later, it is safe to 972 // Since a document without a frame cannot attach one later, it is safe to
967 // exit early. 973 // exit early.
968 if (!frame) 974 if (!frame)
969 return; 975 return;
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
1248 if (RuntimeEnabledFeatures::presentationEnabled()) 1254 if (RuntimeEnabledFeatures::presentationEnabled())
1249 PresentationController::ProvideTo(frame, client->PresentationClient()); 1255 PresentationController::ProvideTo(frame, client->PresentationClient());
1250 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1256 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1251 ProvideAudioOutputDeviceClientTo(frame, 1257 ProvideAudioOutputDeviceClientTo(frame,
1252 new AudioOutputDeviceClientImpl(frame)); 1258 new AudioOutputDeviceClientImpl(frame));
1253 } 1259 }
1254 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher()); 1260 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
1255 } 1261 }
1256 1262
1257 } // namespace blink 1263 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698