Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2878483002: Fix the error message when a new benchmark is added without sharding info (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the error message when a new benchmark is added without sharding info Previously, adding a new benchmark which doesn't have sharding info will raise a cryptic error message " Device affinity for benchmark ... not found". This fixes it by telling the user to contact nednguyen@ & martiniss@ for doing the work of scheduling the benchmark. BUG=chromium:713357 Review-Url: https://codereview.chromium.org/2878483002 Cr-Commit-Position: refs/heads/master@{#470690} Committed: https://chromium.googlesource.com/chromium/src/+/bc4791b8401ea22c9e8dec630c8c49ad9ffe8b9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M tools/perf/core/perf_data_generator.py View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
nednguyen
3 years, 7 months ago (2017-05-10 17:50:10 UTC) #3
rnephew (Reviews Here)
On 2017/05/10 17:50:10, nednguyen wrote: lgtm
3 years, 7 months ago (2017-05-10 18:04:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878483002/1
3 years, 7 months ago (2017-05-10 18:33:42 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:31:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc4791b8401ea22c9e8dec630c8c...

Powered by Google App Engine
This is Rietveld 408576698