Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/perf/core/perf_data_generator.py

Issue 2878483002: Fix the error message when a new benchmark is added without sharding info (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/perf_data_generator.py
diff --git a/tools/perf/core/perf_data_generator.py b/tools/perf/core/perf_data_generator.py
index edcffaabefaaaece0444825572e99b945c64edc8..858cf8181ab7cdff5e86418cd99c7f0cda4cba9b 100755
--- a/tools/perf/core/perf_data_generator.py
+++ b/tools/perf/core/perf_data_generator.py
@@ -674,19 +674,15 @@ def generate_telemetry_tests(name, tester_config, benchmarks,
for dimension in tester_config['swarming_dimensions']:
device = None
sharding_map = benchmark_sharding_map.get(name, None)
- if not sharding_map:
+ device = sharding_map.get(benchmark.Name(), None)
+ if device is None:
raise ValueError('No sharding map for benchmark %r found. Please'
' disable the benchmark with @Disabled(\'all\'), and'
' file a bug with Speed>Benchmarks>Waterfall'
' component and cc martiniss@ and nednguyen@ to'
' execute the benchmark on the waterfall.' % (
- name))
+ benchmark.Name()))
- device = sharding_map.get(benchmark.Name(), None)
-
- if device is None:
- raise Exception('Device affinity for benchmark %s not found'
- % benchmark.Name())
swarming_dimensions.append(get_swarming_dimension(
dimension, device))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698