Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2878473002: Revert of [interpreter] Add intrinsics for map/set instance type checks (Closed)

Created:
3 years, 7 months ago by gdeepti
Modified:
3 years, 7 months ago
Reviewers:
rmcilroy, gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpreter] Add intrinsics for map/set instance type checks (patchset #1 id:1 of https://codereview.chromium.org/2868343002/ ) Reason for revert: Breaks V8 Linux - arm64 - sim - gc stress - https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/6471/steps/Bisect%20f86985ad.Retry/logs/typedarray-every Original issue's description: > [interpreter] Add intrinsics for map/set instance type checks > > BUG=v8:6261, v8:6278, v8:6344 > > Review-Url: https://codereview.chromium.org/2868343002 > Cr-Commit-Position: refs/heads/master@{#45236} > Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a24baa TBR=rmcilroy@chromium.org,gsathya@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2878473002 Cr-Commit-Position: refs/heads/master@{#45239} Committed: https://chromium.googlesource.com/v8/v8/+/386cd83e6e7e955287900f20593157b6f4541652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M src/interpreter/interpreter-intrinsics.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/interpreter/interpreter-intrinsics-generator.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
gdeepti
Created Revert of [interpreter] Add intrinsics for map/set instance type checks
3 years, 7 months ago (2017-05-10 17:34:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878473002/1
3 years, 7 months ago (2017-05-10 17:34:46 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:35:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/386cd83e6e7e955287900f20593157b6f45...

Powered by Google App Engine
This is Rietveld 408576698