Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2868343002:
Reland [interpreter] Add intrinsics for map/set instance type checks (Closed)
DescriptionReland [interpreter] Add intrinsics for map/set instance type checks
BUG=v8:6261, v8:6278, v8:6344
Review-Url: https://codereview.chromium.org/2868343002
Cr-Original-Commit-Position: refs/heads/master@{#45236}
Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a24baa
Review-Url: https://codereview.chromium.org/2868343002
Cr-Commit-Position: refs/heads/master@{#45259}
Committed: https://chromium.googlesource.com/v8/v8/+/c8b77e9614211586b81d2f93bd213c7d62fe51ab
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 ========== to ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 ==========
gsathya@chromium.org changed reviewers: + rmcilroy@chromium.org
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Nice, LGTM. Thanks.
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494433076678860, "parent_rev":
"f86985ad116d75255ddf78b3a4df2590543fd8cd", "commit_rev":
"55a610ba24c819ef24d0efbcc4d2e4a4f6a24baa"}
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 ========== to ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2878473002/ by gdeepti@chromium.org. The reason for reverting is: Breaks V8 Linux - arm64 - sim - gc stress - https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... ========== to ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... ==========
Description was changed from ========== [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... ========== to ========== Reland [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... ==========
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494511936813190, "parent_rev":
"ece19e99b148887b92e58f271d1abc1483d82232", "commit_rev":
"c8b77e9614211586b81d2f93bd213c7d62fe51ab"}
Message was sent while issue was closed.
Description was changed from ========== Reland [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... ========== to ========== Reland [interpreter] Add intrinsics for map/set instance type checks BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2868343002 Cr-Original-Commit-Position: refs/heads/master@{#45236} Committed: https://chromium.googlesource.com/v8/v8/+/55a610ba24c819ef24d0efbcc4d2e4a4f6a... Review-Url: https://codereview.chromium.org/2868343002 Cr-Commit-Position: refs/heads/master@{#45259} Committed: https://chromium.googlesource.com/v8/v8/+/c8b77e9614211586b81d2f93bd213c7d62f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/c8b77e9614211586b81d2f93bd213c7d62f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
