Issue 2878463004: Merge "Forms: Validation Message bubble should not open during print()." to M59.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2878463004: Merge "Forms: Validation Message bubble should not open during print()." to M59. (Closed)

Created:
3 years, 7 months ago by tkent

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

Merge "Forms: Validation Message bubble should not open during print()." to M59. r467941 was a wrong approach because ShouldUsePrintingLayout() returns false before closing print-preview dialog. We should check Page::Suspended() instead. BUG=714849 Review-Url: https://codereview.chromium.org/2866193002 Cr-Original-Commit-Position: refs/heads/master@{#470230} Review-Url: https://codereview.chromium.org/2878463004 . Cr-Commit-Position: refs/branch-heads/3071@{#504} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4ed8907fbd46912db1da904b79bf26ccd41ac1e9

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

tkent

3 years, 7 months ago (2017-05-10 23:53:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4ed8907fbd46912db1da904b79bf26ccd41ac1e9.