Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2866193002: Forms: Validation Message bubble should not open during print(). (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
keishi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Forms: Validation Message bubble should not open during print(). r467941 was a wrong approach because ShouldUsePrintingLayout() returns false before closing print-preview dialog. We should check Page::Suspended() instead. BUG=714849 Review-Url: https://codereview.chromium.org/2866193002 Cr-Commit-Position: refs/heads/master@{#470230} Committed: https://chromium.googlesource.com/chromium/src/+/c55169a7c2279f0f30e15bbca66678f48e7df106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
keishi@, would you review this please? https://codereview.chromium.org/2845273002 was wrong because media query listener with no-printing ...
3 years, 7 months ago (2017-05-09 03:03:51 UTC) #6
keishi
LGTM
3 years, 7 months ago (2017-05-09 04:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866193002/1
3 years, 7 months ago (2017-05-09 04:27:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 05:10:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c55169a7c2279f0f30e15bbca666...

Powered by Google App Engine
This is Rietveld 408576698