Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2877973003: Pull out IDN_Spoof_Checker to separate cc/h files. (Closed)

Created:
3 years, 7 months ago by jungshik at Google
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull out IDN_Spoof_Checker to separate cc/h files. BUG=None TEST=components_unittests=*IDNToUni* Review-Url: https://codereview.chromium.org/2877973003 Cr-Commit-Position: refs/heads/master@{#471627} Committed: https://chromium.googlesource.com/chromium/src/+/d688239189bd18103150f9135931cc632ec3d308

Patch Set 1 #

Patch Set 2 : a bit more tweaks #

Patch Set 3 : rebased #

Patch Set 4 : use raw string literal for dangerous pattern #

Patch Set 5 : comment fix #

Patch Set 6 : fix a typo in regex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -304 lines) Patch
M components/url_formatter/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/url_formatter/idn_spoof_checker.h View 1 2 3 4 5 1 chunk +63 lines, -0 lines 0 comments Download
A components/url_formatter/idn_spoof_checker.cc View 1 2 3 4 5 1 chunk +291 lines, -0 lines 0 comments Download
M components/url_formatter/url_formatter.cc View 1 2 4 chunks +7 lines, -304 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
jungshik at Google
Peter, PTAL.
3 years, 7 months ago (2017-05-13 06:16:52 UTC) #4
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-13 15:56:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877973003/90001
3 years, 7 months ago (2017-05-14 06:32:37 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-14 08:31:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/d688239189bd18103150f9135931...

Powered by Google App Engine
This is Rietveld 408576698