Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2877893003: DevTools: Show product name when available in group by [sub]domain mode. (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Show product name when available in group by [sub]domain mode. BUG=718655 Review-Url: https://codereview.chromium.org/2877893003 Cr-Commit-Position: refs/heads/master@{#471519} Committed: https://chromium.googlesource.com/chromium/src/+/f7cee3b1317d4a51eff3c179dfbb65b0558056c2

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
alph
3 years, 7 months ago (2017-05-12 21:35:10 UTC) #2
caseq
lgtm
3 years, 7 months ago (2017-05-12 21:43:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877893003/1
3 years, 7 months ago (2017-05-12 21:44:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369797)
3 years, 7 months ago (2017-05-12 22:34:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877893003/20001
3 years, 7 months ago (2017-05-12 23:18:50 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 01:05:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7cee3b1317d4a51eff3c179dfbb...

Powered by Google App Engine
This is Rietveld 408576698