Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2877893003: DevTools: Show product name when available in group by [sub]domain mode. (Closed)
Patch Set: update test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 92be83a68fd97f7f095baf03ffb355ec9849254f..9df8e83dd14953fe78839f64d309baf8c3cd1329 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -694,7 +694,13 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
case Timeline.AggregatedTimelineTreeView.GroupBy.Domain:
case Timeline.AggregatedTimelineTreeView.GroupBy.Subdomain:
- return {name: beautifyDomainName.call(this, node.id) || unattributed, color: color};
+ var domainName = beautifyDomainName.call(this, node.id);
+ if (domainName) {
+ var productName = this._productByEvent(/** @type {!SDK.TracingModel.Event} */ (node.event));
+ if (productName)
+ domainName += ' \u2014 ' + productName;
+ }
+ return {name: domainName || unattributed, color: color};
case Timeline.AggregatedTimelineTreeView.GroupBy.EventName:
var name = node.event.name === TimelineModel.TimelineModel.RecordType.JSFrame ?
@@ -722,7 +728,7 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
return {name: frameName, color: color};
default:
- console.assert(false, 'Unexpected aggregation type');
+ console.assert(false, 'Unexpected grouping type');
}
return {name: node.id || unattributed, color: color};
}
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-aggregated-details-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698