Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 2877763002: OneGoogleBarFetcher: replace cmdline flags with feature params (Closed)

Created:
2 years, 2 months ago by Marc Treib
Modified:
2 years, 2 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

OneGoogleBarFetcher: replace cmdline flags with feature params BUG=583292 Review-Url: https://codereview.chromium.org/2877763002 Cr-Commit-Position: refs/heads/master@{#470950} Committed: https://chromium.googlesource.com/chromium/src/+/377048614cb8970f8c621ebb059deb223b1c8b00

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc View 4 chunks +15 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
Marc Treib
PTAL!
2 years, 2 months ago (2017-05-11 11:58:02 UTC) #4
sfiera
LGTM
2 years, 2 months ago (2017-05-11 12:12:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877763002/20001
2 years, 2 months ago (2017-05-11 14:19:44 UTC) #14
commit-bot: I haz the power
2 years, 2 months ago (2017-05-11 14:38:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/377048614cb8970f8c621ebb059d...

Powered by Google App Engine
This is Rietveld 408576698