Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2877483002: Add about:flags entries for UseGoogleLocalNtp and OneGoogleBarOnLocalNtp (Closed)

Created:
1 year, 7 months ago by Marc Treib
Modified:
1 year, 7 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, asvitkine+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add about:flags entries for UseGoogleLocalNtp and OneGoogleBarOnLocalNtp BUG=583292 Review-Url: https://codereview.chromium.org/2877483002 Cr-Commit-Position: refs/heads/master@{#470942} Committed: https://chromium.googlesource.com/chromium/src/+/273e9db78d78aeb54b21bc9dfcaca889d432de2c

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : review #

Patch Set 4 : less ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -9 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/search/search.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/chrome_features.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 4 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
Marc Treib
Another highly-sophisticated CL! PTAL!
1 year, 7 months ago (2017-05-10 14:09:55 UTC) #4
sfiera
LGTM but: https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descriptions.cc File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descriptions.cc#newcode3144 chrome/browser/flag_descriptions.cc:3144: "Use the local NTP if Google is ...
1 year, 7 months ago (2017-05-11 10:39:22 UTC) #7
Marc Treib
https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descriptions.cc File chrome/browser/flag_descriptions.cc (right): https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descriptions.cc#newcode3144 chrome/browser/flag_descriptions.cc:3144: "Use the local NTP if Google is the default ...
1 year, 7 months ago (2017-05-11 11:39:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877483002/60001
1 year, 7 months ago (2017-05-11 13:57:13 UTC) #19
commit-bot: I haz the power
1 year, 7 months ago (2017-05-11 14:02:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/273e9db78d78aeb54b21bc9dfcac...

Powered by Google App Engine
This is Rietveld 408576698