Add about:flags entries for UseGoogleLocalNtp and OneGoogleBarOnLocalNtp

Add about:flags entries for UseGoogleLocalNtp and OneGoogleBarOnLocalNtp

BUG=583292
Review-Url: https://codereview.chromium.org/2877483002
Cr-Commit-Position: refs/heads/master@{#470942}
Committed: https://chromium.googlesource.com/chromium/src/+/273e9db78d78aeb54b21bc9dfcaca889d432de2c

[Marc Treib, 2017-05-10 14:08:24]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 14:09:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-05-10 14:09:54]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-05-10 14:09:55]

Another highly-sophisticated CL! PTAL!

[commit-bot: I haz the power, 2017-05-10 15:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:15:50]

Dry run: This issue passed the CQ dry run.

[sfiera, 2017-05-11 10:39:22]

LGTM but:

https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descrip...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descrip...
chrome/browser/flag_descriptions.cc:3144: "Use the local NTP if Google is the
default search engine.";
For the descriptions, I think it would be better to spell out "New Tab Page" in
full.

https://codereview.chromium.org/2877483002/diff/1/chrome/common/chrome_featur...
File chrome/common/chrome_features.h (right):

https://codereview.chromium.org/2877483002/diff/1/chrome/common/chrome_featur...
chrome/common/chrome_features.h:135: extern const base::Feature
kOneGoogleBarOnLocalNtp;
This feature will now be exposed to Android, won't it?

(was it before?)

[Marc Treib, 2017-05-11 11:38:39]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 11:38:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-05-11 11:39:54]

https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descrip...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2877483002/diff/1/chrome/browser/flag_descrip...
chrome/browser/flag_descriptions.cc:3144: "Use the local NTP if Google is the
default search engine.";
On 2017/05/11 10:39:22, sfiera wrote:
> For the descriptions, I think it would be better to spell out "New Tab Page"
in
> full.

Done.

https://codereview.chromium.org/2877483002/diff/1/chrome/common/chrome_featur...
File chrome/common/chrome_features.h (right):

https://codereview.chromium.org/2877483002/diff/1/chrome/common/chrome_featur...
chrome/common/chrome_features.h:135: extern const base::Feature
kOneGoogleBarOnLocalNtp;
On 2017/05/11 10:39:22, sfiera wrote:
> This feature will now be exposed to Android, won't it?

Yes, good catch!

> (was it before?)

No, local_ntp_source.cc is not built on Android (I just checked).

TBH I don't think it matters much, but I've put ifdefs around everything.

[commit-bot: I haz the power, 2017-05-11 12:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 12:09:04]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Marc Treib, 2017-05-11 12:17:26]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 12:17:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 13:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 13:53:42]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-05-11 13:56:31]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-05-11 13:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sfiera@chromium.org
Link to the patchset: https://codereview.chromium.org/2877483002/#ps60001
(title: "less ifdef")

[commit-bot: I haz the power, 2017-05-11 13:57:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:02:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494510991827990,
"parent_rev": "c6737bb033e394fa654ef8ac2faa12306aaf062d", "commit_rev":
"273e9db78d78aeb54b21bc9dfcaca889d432de2c"}

[commit-bot: I haz the power, 2017-05-11 14:02:42]

Description was changed from

==========
Add about:flags entries for UseGoogleLocalNtp and OneGoogleBarOnLocalNtp

BUG=583292
==========

to

==========
Add about:flags entries for UseGoogleLocalNtp and OneGoogleBarOnLocalNtp

BUG=583292

Review-Url: https://codereview.chromium.org/2877483002
Cr-Commit-Position: refs/heads/master@{#470942}
Committed:
https://chromium.googlesource.com/chromium/src/+/273e9db78d78aeb54b21bc9dfcac...
==========

[commit-bot: I haz the power, 2017-05-11 14:02:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/273e9db78d78aeb54b21bc9dfcac...