Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2877703003: Improve LayoutMultiColumnFlowThread::IsPageLogicalHeightKnown(). (Closed)

Created:
3 years, 7 months ago by mstensho (USE GERRIT)
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve LayoutMultiColumnFlowThread::IsPageLogicalHeightKnown(). Simply returning whether the last column set has a known height isn't really sufficient. All column sets need to have known heights. However, instead of asking each column set every time we call LayoutMultiColumnFlowThread::IsPageLogicalHeightKnown(), use a flag. BUG=709792, 717939 Review-Url: https://codereview.chromium.org/2877703003 Cr-Commit-Position: refs/heads/master@{#471231} Committed: https://chromium.googlesource.com/chromium/src/+/079f4500332799e2e3e03eb15243b1b8d5342fe6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/float-with-overflow-before-spanner-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 4 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
mstensho (USE GERRIT)
3 years, 7 months ago (2017-05-11 15:29:17 UTC) #6
eae
LGTM
3 years, 7 months ago (2017-05-11 16:47:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877703003/1
3 years, 7 months ago (2017-05-11 16:51:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452045)
3 years, 7 months ago (2017-05-11 18:55:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877703003/1
3 years, 7 months ago (2017-05-11 20:25:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452275)
3 years, 7 months ago (2017-05-11 23:25:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877703003/1
3 years, 7 months ago (2017-05-12 05:17:24 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 05:58:13 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/079f4500332799e2e3e03eb15243...

Powered by Google App Engine
This is Rietveld 408576698