third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp - Issue 2877703003: Improve LayoutMultiColumnFlowThread::IsPageLogicalHeightKnown().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2877703003: Improve LayoutMultiColumnFlowThread::IsPageLogicalHeightKnown(). (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

index 540dbd3c8de5a9112a7b7c59384ef6b698f2e479..1201a5f442929a4726bdcb704c9a9f33c07bc53c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

@@ -445,7 +445,7 @@ void LayoutBlockFlow::UpdateBlockLayout(bool relayout_children) {

LayoutChildren(relayout_children, layout_scope);

}

- if (flow_thread && flow_thread->ColumnHeightsChanged()) {

+ if (flow_thread && !flow_thread->FinishLayout()) {

SetChildNeedsLayout(kMarkOnlyThis);

continue;

}