Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2877063003: [TTS] Fix metrics on re-tap to count both taps. (Closed)

Created:
3 years, 7 months ago by Donn Denman
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Fix metrics on re-tap to count both taps. When the user taps next to the selection when the bar is already showing the bar doesn't hide and reshow, but the searches are considered separate. Currently we only update metrics for one of these taps, but we're supposed to update for each search. This change adds an override to ContextualSearchPanel to call peekpanel when requestPanelShow is called in the case where it's already peeking. BUG=721953 Review-Url: https://codereview.chromium.org/2877063003 Cr-Commit-Position: refs/heads/master@{#471848} Committed: https://chromium.googlesource.com/chromium/src/+/b4155a0bbd8b968baa44f8c9656e86e351b4e50a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Donn Denman
Theresa, PTAL. Thanks!
3 years, 7 months ago (2017-05-15 17:32:58 UTC) #6
Theresa
lgtm
3 years, 7 months ago (2017-05-15 17:39:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877063003/1
3 years, 7 months ago (2017-05-15 17:43:16 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 18:51:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4155a0bbd8b968baa44f8c9656e...

Powered by Google App Engine
This is Rietveld 408576698