Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java

Issue 2877063003: [TTS] Fix metrics on re-tap to count both taps. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
index 58e0a44579bd7a62a658c1e82422f2921e7d1428..ca02f022d1fa04218dd1174598e55be7439a1683 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
@@ -533,6 +533,16 @@ public class ContextualSearchPanel extends OverlayPanel {
return super.getPanelState();
}
+ @Override
+ public void requestPanelShow(StateChangeReason reason) {
+ // If a re-tap is causing the panel to show when already shown, the superclass may ignore
+ // that, but we want to be sure to capture search metrics for each tap.
+ if (isShowing() && getPanelState() == PanelState.PEEKED) {
+ peekPanel(reason);
+ }
+ super.requestPanelShow(reason);
+ }
+
/**
* Gets whether a touch on the content view has been done yet or not.
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698