Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2876943002: Flowthread should move its floatlists to container when evacuating (Closed)

Created:
3 years, 7 months ago by rhogan
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Flowthread should move its floatlists to container when evacuating This ensures that if any of the floats gets deleted the new container will be able to delete from its new descendants' float-lists. BUG=714440 Review-Url: https://codereview.chromium.org/2863093004 Cr-Commit-Position: refs/heads/master@{#470128} (cherry picked from commit a925ec8c709dcc3768dfeb349bf19c766d6f5c7d) Review-Url: https://codereview.chromium.org/2876943002 . Cr-Commit-Position: refs/branch-heads/3071@{#519} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/37b22ee298b3cde4c44ffc5ab83449c26b0dfe59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/flowthread-with-floats-destroyed-crash.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
rhogan
3 years, 7 months ago (2017-05-11 21:55:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37b22ee298b3cde4c44ffc5ab83449c26b0dfe59.

Powered by Google App Engine
This is Rietveld 408576698