third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp - Issue 2876943002: Flowthread should move its floatlists to container when evacuating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 2876943002: Flowthread should move its floatlists to container when evacuating (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

index bc5b01e48b75def0b215daf8326f3bead7df5a54..80b7592ed915b6e4d9045b8d6632c76524e24976 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

@@ -314,7 +314,7 @@ void LayoutMultiColumnFlowThread::EvacuateAndDestroy() {

// they aren't just re-added again to the flow thread that we're trying to

// empty.

multicol_container->ResetMultiColumnFlowThread();

- MoveAllChildrenTo(multicol_container, true);

+ MoveAllChildrenIncludingFloatsTo(multicol_container, true);

// We used to manually nuke the line box tree here, but that should happen

// automatically when moving children around (the code above).

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »