Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2876813002: Implement generalized function types. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Implement generalized function types. #

Patch Set 3 : Fixes for analyzer and dart2js. #

Total comments: 8

Patch Set 4 : Merged with 9820535bc17ac92bbb80bdf98274efd1a38cdaf7. #

Patch Set 5 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+589 lines, -590 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 2 3 9 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 2 3 2 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 2 4 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/errors.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes.dart View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 2 50 chunks +88 lines, -68 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 3 8 chunks +20 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 1 2 2 chunks +4 lines, -35 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/modifier.dart View 1 5 chunks +10 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/identifier_context.dart View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 2 3 4 31 chunks +305 lines, -309 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 2 3 11 chunks +28 lines, -16 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_parser.dart View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 2 3 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/unhandled_listener.dart View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/messages.yaml View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/src/analyze.dart View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 6 chunks +4 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/dump_info_test.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 6 chunks +2 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ahe
3 years, 7 months ago (2017-05-11 13:04:01 UTC) #2
ahe
Hold off reviewing this. I have more changes to this area.
3 years, 7 months ago (2017-05-11 14:06:58 UTC) #3
ahe
Finally ready for review.
3 years, 7 months ago (2017-05-18 13:42:39 UTC) #7
Johnni Winther
lgtm https://codereview.chromium.org/2876813002/diff/60001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2876813002/diff/60001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode694 pkg/front_end/lib/src/fasta/parser/parser.dart:694: Token token, FormalParameterType kind, MemberKind memberKind) { Rename ...
3 years, 7 months ago (2017-05-19 08:23:39 UTC) #8
ahe
Thank you, Johnni! https://codereview.chromium.org/2876813002/diff/60001/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2876813002/diff/60001/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode694 pkg/front_end/lib/src/fasta/parser/parser.dart:694: Token token, FormalParameterType kind, MemberKind memberKind) ...
3 years, 7 months ago (2017-05-19 09:02:48 UTC) #9
ahe
3 years, 7 months ago (2017-05-19 09:03:33 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) manually as
547b2cdcceb29fdff0f5261a30f4fc8c1a7676ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698