Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2876813002: Implement generalized function types. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/tool/_fasta/generate_messages.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index 38324578eb580224d94f9e0b942070cef0c29921..ae689c8cf2ee4b167063f85169b7ca67473d4a6e 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -166,8 +166,10 @@ Future<Null> analyzeUris(Uri analysisOptions, Uri packages, List<Uri> uris,
bool hasOutput = false;
Set<String> seen = new Set<String>();
for (AnalyzerDiagnostic diagnostic in diagnostics) {
- String path = diagnostic.uri?.path ?? "<unknown>";
- if (exclude.any((RegExp r) => path.contains(r))) continue;
+ String path = diagnostic.uri?.path;
+ if (path != null && exclude.any((RegExp r) => path.contains(r))) {
+ continue;
+ }
String message = "$diagnostic";
if (seen.add(message)) {
hasOutput = true;
« no previous file with comments | « pkg/front_end/tool/_fasta/generate_messages.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698