Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: pkg/front_end/lib/src/fasta/parser/listener.dart

Issue 2876813002: Implement generalized function types. (Closed)
Patch Set: Address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/parser/listener.dart
diff --git a/pkg/front_end/lib/src/fasta/parser/listener.dart b/pkg/front_end/lib/src/fasta/parser/listener.dart
index 1c2c22da14523a2e6752f7b4c979c5f2b90c7655..95a35ea679bf3c828d6b9c78443908b9e55a6100 100644
--- a/pkg/front_end/lib/src/fasta/parser/listener.dart
+++ b/pkg/front_end/lib/src/fasta/parser/listener.dart
@@ -12,7 +12,7 @@ import '../scanner/token.dart' show BeginGroupToken, SymbolToken;
import '../util/link.dart' show Link;
-import 'parser.dart' show FormalParameterType;
+import 'parser.dart' show FormalParameterType, MemberKind;
import 'identifier_context.dart' show IdentifierContext;
@@ -180,20 +180,21 @@ class Listener {
logEvent("FactoryMethod");
}
- void beginFormalParameter(Token token) {}
+ void beginFormalParameter(Token token, MemberKind kind) {}
- void endFormalParameter(Token covariantKeyword, Token thisKeyword,
- Token nameToken, FormalParameterType kind) {
+ void endFormalParameter(Token thisKeyword, Token nameToken,
+ FormalParameterType kind, MemberKind memberKind) {
logEvent("FormalParameter");
}
- void handleNoFormalParameters(Token token) {
+ void handleNoFormalParameters(Token token, MemberKind kind) {
logEvent("NoFormalParameters");
}
- void beginFormalParameters(Token token) {}
+ void beginFormalParameters(Token token, MemberKind kind) {}
- void endFormalParameters(int count, Token beginToken, Token endToken) {
+ void endFormalParameters(
+ int count, Token beginToken, Token endToken, MemberKind kind) {
logEvent("FormalParameters");
}
@@ -204,8 +205,7 @@ class Listener {
/// - Variable declarations (count times)
///
/// Doesn't have a corresponding begin event, use [beginMember] instead.
- void endFields(
- int count, Token covariantKeyword, Token beginToken, Token endToken) {
+ void endFields(int count, Token beginToken, Token endToken) {
logEvent("Fields");
}
@@ -815,7 +815,7 @@ class Listener {
/// - type parameters
/// - formal parameters
void endFunctionTypedFormalParameter(
- Token covariantKeyword, Token thisKeyword, FormalParameterType kind) {
+ Token thisKeyword, FormalParameterType kind) {
logEvent("FunctionTypedFormalParameter");
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/parser/identifier_context.dart ('k') | pkg/front_end/lib/src/fasta/parser/parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698