third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl - Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl ('k') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

index 3519dab86a907a2a5ad940791fc8308e2c2fce20..efc4644c0b5af0b077763b43b20d16da7232f6bc 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

@@ -96,14 +96,14 @@ unsigned {{field.name}} : {{field.size}}; // {{field.type_name}}

{% endfor %}

{% endmacro %}

-{% macro fieldwise_diff(group_to_diff) %}

+{% macro fieldwise_diff(self, group_to_diff) %}

{% for group in group_to_diff.subgroups %}

if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) {

}

{% endfor %}

{% for expression in group_to_diff.expressions %}

-if ({{expression}} != other.{{expression}})

+if ({{self}}.{{expression}} != other.{{expression}})

return true;

{% endfor %}

{% endmacro %}