Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)
Patch Set: shend@'s suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% macro encode(field, value) %} 1 {% macro encode(field, value) %}
2 {% if field.is_bit_field -%} 2 {% if field.is_bit_field -%}
3 static_cast<unsigned>({{value}}) 3 static_cast<unsigned>({{value}})
4 {%- else -%} 4 {%- else -%}
5 {{value}} 5 {{value}}
6 {%- endif %} 6 {%- endif %}
7 {% endmacro %} 7 {% endmacro %}
8 8
9 {% macro decode(field, value) %} 9 {% macro decode(field, value) %}
10 {% if field.is_bit_field -%} 10 {% if field.is_bit_field -%}
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 {{subgroup.member_name}} = other.{{subgroup.member_name}}; 89 {{subgroup.member_name}} = other.{{subgroup.member_name}};
90 {% elif subgroup.fields|select("in", fields_to_copy)|list|length > 0 -%} 90 {% elif subgroup.fields|select("in", fields_to_copy)|list|length > 0 -%}
91 {{fieldwise_copy(subgroup, fields_to_copy)}} 91 {{fieldwise_copy(subgroup, fields_to_copy)}}
92 {% endif %} 92 {% endif %}
93 {% endfor %} 93 {% endfor %}
94 {% for field in group.fields|select("in", fields_to_copy) -%} 94 {% for field in group.fields|select("in", fields_to_copy) -%}
95 {{setter_expression(field)}} = other.{{getter_expression(field)}}; 95 {{setter_expression(field)}} = other.{{getter_expression(field)}};
96 {% endfor %} 96 {% endfor %}
97 {% endmacro %} 97 {% endmacro %}
98 98
99 {% macro fieldwise_diff(group_to_diff) %} 99 {% macro fieldwise_diff(self, group_to_diff) %}
100 {% for group in group_to_diff.subgroups %} 100 {% for group in group_to_diff.subgroups %}
101 if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) { 101 if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) {
102 {{fieldwise_diff(group)|indent(2, true)}} 102 {{fieldwise_diff(group)|indent(2, true)}}
103 } 103 }
104 {% endfor %} 104 {% endfor %}
105 {% for expression in group_to_diff.expressions %} 105 {% for expression in group_to_diff.expressions %}
106 if ({{expression}} != other.{{expression}}) 106 if ({{self}}.{{expression}} != other.{{expression}})
107 return true; 107 return true;
108 {% endfor %} 108 {% endfor %}
109 {% endmacro %} 109 {% endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698