third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl - Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2876803003: Generate diffs for fields in ComputedStyle that use their public getters (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

index cc98bc3437826210b5bcd6e7df41e7dc4c68aa7d..06c2ba99ff9fef47c3883bb27ee148f62374f3b7 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

@@ -128,7 +128,8 @@ class CORE_EXPORT ComputedStyleBase {

{% for name, groups_to_diff in diff_functions_map.items() %}

bool {{name}}(const ComputedStyleFinal& other) const {

- {{fieldwise_diff(groups_to_diff)|indent(2)}}

+ const ComputedStyleFinal& self = static_cast<const ComputedStyleFinal&>(*this);

+ {{fieldwise_diff(self, groups_to_diff)|indent(2)}}

shend 2017/05/12 07:10:41 might have to be "self" in quotes.

nainar 2017/05/12 07:14:31 yup. lol .done

return false;

}

{% endfor %}