Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2876743002: Reland of App button click exits WebVR presentation. (Closed)

Created:
3 years, 7 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
tiborg, cjgrant, amp
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of App button click exits WebVR presentation. (patchset #1 id:1 of https://codereview.chromium.org/2874103003/ ) Reason for revert: I reverted an innocent CL. Original issue's description: > Revert of App button click exits WebVR presentation. (patchset #5 id:80001 of https://codereview.chromium.org/2867783002/ ) > > Reason for revert: > Causes failures on a MSAN bot. > https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440 > > Original issue's description: > > App button click exits WebVR presentation. > > > > BUG=715730 > > > > Review-Url: https://codereview.chromium.org/2867783002 > > Cr-Commit-Position: refs/heads/master@{#470605} > > Committed: https://chromium.googlesource.com/chromium/src/+/ea6cba18fb2e07477a7992cc027677f37a9b772e > > TBR=cjgrant@chromium.org,amp@chromium.org,tiborg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=715730 > > Review-Url: https://codereview.chromium.org/2874103003 > Cr-Commit-Position: refs/heads/master@{#470789} > Committed: https://chromium.googlesource.com/chromium/src/+/e6ac7322836b02036f2758a16b520b00e1330cb3 TBR=cjgrant@chromium.org,amp@chromium.org,tiborg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715730 Review-Url: https://codereview.chromium.org/2876743002 Cr-Commit-Position: refs/heads/master@{#470792} Committed: https://chromium.googlesource.com/chromium/src/+/049fd5ff8ae50270cc8c9994b841c2e4e43b9703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_browser_interface.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
yhirano
Created Reland of App button click exits WebVR presentation.
3 years, 7 months ago (2017-05-11 03:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876743002/1
3 years, 7 months ago (2017-05-11 03:22:02 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 03:23:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/049fd5ff8ae50270cc8c9994b841...

Powered by Google App Engine
This is Rietveld 408576698