Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Issue 2874103003: Revert of App button click exits WebVR presentation. (Closed)

Created:
3 years, 7 months ago by yhirano
Modified:
3 years, 7 months ago
Reviewers:
tiborg, cjgrant, amp
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of App button click exits WebVR presentation. (patchset #5 id:80001 of https://codereview.chromium.org/2867783002/ ) Reason for revert: Causes failures on a MSAN bot. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/440 Original issue's description: > App button click exits WebVR presentation. > > BUG=715730 > > Review-Url: https://codereview.chromium.org/2867783002 > Cr-Commit-Position: refs/heads/master@{#470605} > Committed: https://chromium.googlesource.com/chromium/src/+/ea6cba18fb2e07477a7992cc027677f37a9b772e TBR=cjgrant@chromium.org,amp@chromium.org,tiborg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715730 Review-Url: https://codereview.chromium.org/2874103003 Cr-Commit-Position: refs/heads/master@{#470789} Committed: https://chromium.googlesource.com/chromium/src/+/e6ac7322836b02036f2758a16b520b00e1330cb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -29 lines) Patch
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_browser_interface.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_thread.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yhirano
Created Revert of App button click exits WebVR presentation.
3 years, 7 months ago (2017-05-11 03:10:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874103003/1
3 years, 7 months ago (2017-05-11 03:11:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e6ac7322836b02036f2758a16b520b00e1330cb3
3 years, 7 months ago (2017-05-11 03:12:34 UTC) #6
yhirano
3 years, 7 months ago (2017-05-11 03:18:08 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2876743002/ by yhirano@chromium.org.

The reason for reverting is: I reverted a innocent CL..

Powered by Google App Engine
This is Rietveld 408576698