Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2876733002: IPH UI : Fix text bubble x-alignment (Closed)

Created:
3 years, 7 months ago by shaktisahu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IPH UI : Fix text bubble x-alignment Using menu button instead of menu anchor fixes the alignment. BUG=721164 Review-Url: https://codereview.chromium.org/2876733002 Cr-Commit-Position: refs/heads/master@{#472594} Committed: https://chromium.googlesource.com/chromium/src/+/5781ee5811becfe6c87bff86a1e0b507cb5f3b97

Patch Set 1 #

Patch Set 2 : Replaced menu anchor with menu button #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
shaktisahu
PTAL
3 years, 7 months ago (2017-05-11 02:17:36 UTC) #2
David Trainor- moved to gerrit
lgtm Do we still need getMenuAnchor()?
3 years, 7 months ago (2017-05-12 15:50:48 UTC) #7
shaktisahu
On 2017/05/12 15:50:48, David Trainor-ping if over 24h wrote: > lgtm > > Do we ...
3 years, 7 months ago (2017-05-15 16:57:08 UTC) #12
David Trainor- moved to gerrit
still lgtm if you test with the badge up.
3 years, 7 months ago (2017-05-16 23:56:23 UTC) #13
shaktisahu
On 2017/05/16 23:56:23, David Trainor-ping if over 24h wrote: > still lgtm if you test ...
3 years, 7 months ago (2017-05-17 21:34:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876733002/20001
3 years, 7 months ago (2017-05-17 21:37:34 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 22:53:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5781ee5811becfe6c87bff86a1e0...

Powered by Google App Engine
This is Rietveld 408576698