Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 2876733002: IPH UI : Fix text bubble x-alignment (Closed)
Patch Set: Replaced menu anchor with menu button Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
index 1ed871d536b3e2962d33c7c83c012460ff55db0e..1dcdbcc9ab5cc16fcad6f1bebf9babbdb7f4ec8f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
@@ -527,7 +527,7 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
if (!tracker.shouldTriggerHelpUI(FeatureConstants.DOWNLOAD_PAGE_FEATURE)) return;
- mTextBubble = new ViewAnchoredTextBubble(mToolbar.getContext(), getMenuAnchor(),
+ mTextBubble = new ViewAnchoredTextBubble(mToolbar.getContext(), getMenuButton(),
R.string.iph_download_page_for_offline_usage_text,
R.string.iph_download_page_for_offline_usage_accessibility_text);
mTextBubble.setDismissOnTouchInteraction(true);
@@ -800,10 +800,10 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
}
/**
- * @return The view that the pop up menu should be anchored to on the UI.
+ * @return The view containing the pop up menu button.
*/
- public View getMenuAnchor() {
- return mToolbar.getMenuButtonWrapper();
+ public View getMenuButton() {
+ return mToolbar.getMenuButton();
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698