Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2876553002: [heap] Slot snapshot for visiting JSObjects in concurrent marker. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Slot snapshot for visiting JSObjects in concurrent marker. The mutator can convert a pointer slot of a JSObject to an unboxed double slot. To make it we safe for the concurrent marker, we require synchronization using the object markbits. The concurrent marker visits the JSObject as follows: - save snapshot of object slot addresses and values. - visit the snapshot only after successful transition of the object from grey to black. Before an unsafe layout change the mutator colors the object black and visits it using the bailout marking deque. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2876553002 Cr-Commit-Position: refs/heads/master@{#45254} Committed: https://chromium.googlesource.com/v8/v8/+/8a5382b78947fb126ad5a81051c2aced40e97d2e

Patch Set 1 #

Patch Set 2 : revert flags #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
M src/heap/concurrent-marking.cc View 1 2 3 chunks +64 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
ulan
ptal
3 years, 7 months ago (2017-05-10 14:18:23 UTC) #3
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-10 15:56:34 UTC) #4
Hannes Payer (out of office)
lgtm
3 years, 7 months ago (2017-05-11 10:40:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876553002/40001
3 years, 7 months ago (2017-05-11 10:40:54 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 11:11:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/8a5382b78947fb126ad5a81051c2aced40e...

Powered by Google App Engine
This is Rietveld 408576698