[heap] Color object black on unsafe layout change.

[heap] Color object black on unsafe layout change.

This is a part of synchronization protocol with the concurrent marking.

BUG=chromium:694255
Review-Url: https://codereview.chromium.org/2872323002
Cr-Commit-Position: refs/heads/master@{#45262}
Committed: https://chromium.googlesource.com/v8/v8/+/ee41ee6bd7854aeb3e74b5a8784dd107b03fa904

[ulan, 2017-05-10 15:33:05]

Description was changed from

==========
[heap] Color object black on unsafe layout change.

BUG=chromium:694255
==========

to

==========
[heap] Color object black on unsafe layout change.

This is a part of synchronization protocol with the concurrent marking.

BUG=chromium:694255
==========

[ulan, 2017-05-10 15:33:44]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[ulan, 2017-05-10 15:33:45]

ptal

[Hannes Payer (out of office), 2017-05-10 20:37:45]

https://codereview.chromium.org/2872323002/diff/1/src/heap/incremental-markin...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/2872323002/diff/1/src/heap/incremental-markin...
src/heap/incremental-marking.cc:883: // 2. The object is a JSObject that was
colored black before
Don't you want to bail out for black JSObjects?

[ulan, 2017-05-11 10:37:24]

https://codereview.chromium.org/2872323002/diff/1/src/heap/incremental-markin...
File src/heap/incremental-marking.cc (right):

https://codereview.chromium.org/2872323002/diff/1/src/heap/incremental-markin...
src/heap/incremental-marking.cc:883: // 2. The object is a JSObject that was
colored black before
On 2017/05/10 20:37:45, Hannes Payer wrote:
> Don't you want to bail out for black JSObjects?

As discussed offline we now have to handle black JSObject on the main thread
because they are colored black on layout change and pushed into the bailout
queue.

[Hannes Payer (out of office), 2017-05-11 10:38:27]

lgtm

[ulan, 2017-05-11 14:44:04]

ptal, I changed Marking:: to ObjectMarking:: and added handling of marking deque
overflow.

[Michael Lippautz, 2017-05-11 14:45:14]

lgtm

[ulan, 2017-05-11 14:50:54]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-05-11 14:50:54]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2872323002/#ps40001
(title: "handle marking deque overflow")

[commit-bot: I haz the power, 2017-05-11 14:51:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:54:31]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[ulan, 2017-05-11 14:57:00]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-05-11 14:57:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2872323002/#ps60001
(title: "fix unused variable")

[commit-bot: I haz the power, 2017-05-11 14:57:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 15:34:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494514620061070,
"parent_rev": "7a88f72946b28a45f04d5a9b53e348af2eef69d5", "commit_rev":
"ee41ee6bd7854aeb3e74b5a8784dd107b03fa904"}

[commit-bot: I haz the power, 2017-05-11 15:34:16]

Description was changed from

==========
[heap] Color object black on unsafe layout change.

This is a part of synchronization protocol with the concurrent marking.

BUG=chromium:694255
==========

to

==========
[heap] Color object black on unsafe layout change.

This is a part of synchronization protocol with the concurrent marking.

BUG=chromium:694255

Review-Url: https://codereview.chromium.org/2872323002
Cr-Commit-Position: refs/heads/master@{#45262}
Committed:
https://chromium.googlesource.com/v8/v8/+/ee41ee6bd7854aeb3e74b5a8784dd107b03...
==========

[commit-bot: I haz the power, 2017-05-11 15:34:17]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/ee41ee6bd7854aeb3e74b5a8784dd107b03...