Use WTF::TimeDelta to specify delays on WebTaskRunner

Use WTF::TimeDelta to specify delays on WebTaskRunner

WebTaskRunner had 3 variants of PostTask to post a delayed task. And among
that, one takes a double for the delay parameter, and others takes a long long.
While most of other parts of Blink uses double for a time delta in milliseconds
or seconds. That is sometimes confusing.

This CL replaces the type of delay parameter of WebTaskRunner with WTF::TimeDelta,
which is an alias of base::TimeDelta, and updates all callers.
Plus, this removes an overload of PostTask that has only one caller in the
production.

Review-Url: https://codereview.chromium.org/2876513002
Cr-Commit-Position: refs/heads/master@{#470931}
Committed: https://chromium.googlesource.com/chromium/src/+/3c84cbfc6e50987a39ee77140bdbb124970e6c58

[tzik, 2017-05-10 11:47:18]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 11:48:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-10 12:02:13]

Description was changed from

==========
Use WTF::TimeDelta to specify delays on WebTaskRunner
==========

to

==========
Use WTF::TimeDelta to specify delays on WebTaskRunner

123456789012345678901234567890123456789012345678901234567890123456789012

WebTaskRunner had 3 variants of PostTask to post a delayed task. And among
that, one takes a double for the delay parameter, and others takes a long long.
While most of other parts of Blink uses double for a time delta in milliseconds
or seconds. That is sometimes confusing.

This CL replaces the type of delay parameter of WebTaskRunner with
WTF::TimeDelta,
which is an alias of base::TimeDelta, and updates all callers.
Plus, this removes an overload of PostTask that has only one caller in the
production.
==========

[tzik, 2017-05-10 12:02:23]

Description was changed from

==========
Use WTF::TimeDelta to specify delays on WebTaskRunner

123456789012345678901234567890123456789012345678901234567890123456789012

WebTaskRunner had 3 variants of PostTask to post a delayed task. And among
that, one takes a double for the delay parameter, and others takes a long long.
While most of other parts of Blink uses double for a time delta in milliseconds
or seconds. That is sometimes confusing.

This CL replaces the type of delay parameter of WebTaskRunner with
WTF::TimeDelta,
which is an alias of base::TimeDelta, and updates all callers.
Plus, this removes an overload of PostTask that has only one caller in the
production.
==========

to

==========
Use WTF::TimeDelta to specify delays on WebTaskRunner

WebTaskRunner had 3 variants of PostTask to post a delayed task. And among
that, one takes a double for the delay parameter, and others takes a long long.
While most of other parts of Blink uses double for a time delta in milliseconds
or seconds. That is sometimes confusing.

This CL replaces the type of delay parameter of WebTaskRunner with
WTF::TimeDelta,
which is an alias of base::TimeDelta, and updates all callers.
Plus, this removes an overload of PostTask that has only one caller in the
production.
==========

[tzik, 2017-05-10 13:07:31]

tzik@chromium.org changed reviewers:
+ alexclarke@chromium.org, haraken@chromium.org, nhiroki@chromium.org

[tzik, 2017-05-10 13:07:32]

PTAL to:
alexclarke: WebTaskRunner and scheduler.
haraken: others as an OWNER.
nhiroki: FYI.

[alex clarke (OOO till 29th), 2017-05-10 13:12:44]

Nice LGTM

[commit-bot: I haz the power, 2017-05-10 13:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 13:53:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-05-10 14:24:03]

nice!

(lgtm)

[haraken, 2017-05-10 15:12:54]

LGTM

https://codereview.chromium.org/2876513002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp (right):

https://codereview.chromium.org/2876513002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp:120:
WTF::TimeDelta::FromMilliseconds(timeout_millis));

WTF:: wouldn't be needed.

[Sami, 2017-05-10 15:30:10]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2017-05-10 15:30:10]

lgtm. It's a little unfortunate that we need to add ToSingleThreadTaskRunner()
in a few places, but I guess we can replace more of the base::Binds with
WTF::Bind later.

[nhiroki, 2017-05-10 23:29:02]

lgtm!

[tzik, 2017-05-11 07:15:18]

https://codereview.chromium.org/2876513002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp (right):

https://codereview.chromium.org/2876513002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp:120:
WTF::TimeDelta::FromMilliseconds(timeout_millis));
On 2017/05/10 15:12:54, haraken wrote:
> 
> WTF:: wouldn't be needed.

Done.

[tzik, 2017-05-11 07:15:25]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-11 07:15:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kinuko@chromium.org, skyostil@chromium.org,
nhiroki@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2876513002/#ps20001
(title: "rebase. WTF::TimeDelta -> TimeDelta")

[commit-bot: I haz the power, 2017-05-11 07:16:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 07:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 07:48:40]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tzik, 2017-05-11 09:38:10]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 09:38:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-11 10:15:14]

The CQ bit was unchecked by tzik@chromium.org

[tzik, 2017-05-11 10:15:20]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-05-11 10:15:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kinuko@chromium.org, skyostil@chromium.org,
nhiroki@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/2876513002/#ps40001
(title: "mac fix")

[commit-bot: I haz the power, 2017-05-11 10:15:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 12:27:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494497720953150,
"parent_rev": "abc61bbbad13394f8286af84eb49d60d3f4b1882", "commit_rev":
"3c84cbfc6e50987a39ee77140bdbb124970e6c58"}

[commit-bot: I haz the power, 2017-05-11 12:27:27]

Description was changed from

==========
Use WTF::TimeDelta to specify delays on WebTaskRunner

WebTaskRunner had 3 variants of PostTask to post a delayed task. And among
that, one takes a double for the delay parameter, and others takes a long long.
While most of other parts of Blink uses double for a time delta in milliseconds
or seconds. That is sometimes confusing.

This CL replaces the type of delay parameter of WebTaskRunner with
WTF::TimeDelta,
which is an alias of base::TimeDelta, and updates all callers.
Plus, this removes an overload of PostTask that has only one caller in the
production.
==========

to

==========
Use WTF::TimeDelta to specify delays on WebTaskRunner

WebTaskRunner had 3 variants of PostTask to post a delayed task. And among
that, one takes a double for the delay parameter, and others takes a long long.
While most of other parts of Blink uses double for a time delta in milliseconds
or seconds. That is sometimes confusing.

This CL replaces the type of delay parameter of WebTaskRunner with
WTF::TimeDelta,
which is an alias of base::TimeDelta, and updates all callers.
Plus, this removes an overload of PostTask that has only one caller in the
production.

Review-Url: https://codereview.chromium.org/2876513002
Cr-Commit-Position: refs/heads/master@{#470931}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c84cbfc6e50987a39ee77140bdb...
==========

[commit-bot: I haz the power, 2017-05-11 12:27:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c84cbfc6e50987a39ee77140bdb...