third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc - Issue 2876513002: Use WTF::TimeDelta to specify delays on WebTaskRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

Issue 2876513002: Use WTF::TimeDelta to specify delays on WebTaskRunner (Closed)

Patch Set: mac fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

index 1d2711541c35ecbce9c1088426c79016aa0a71a7..578186687c593bbda7ef1449049124b10be99fae 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc

@@ -151,8 +151,8 @@ TEST_F(WebThreadImplForWorkerSchedulerTest, TestIdleTask) {

thread_->PostIdleTask(BLINK_FROM_HERE, task.release());

// We need to post a wake-up task or idle work will never happen.

- thread_->GetWebTaskRunner()->PostDelayedTask(BLINK_FROM_HERE,

- WTF::Bind([] {}), 50ll);

+ thread_->GetWebTaskRunner()->PostDelayedTask(

+ BLINK_FROM_HERE, WTF::Bind([] {}), TimeDelta::FromMilliseconds(50));

completion.Wait();

}

@@ -188,7 +188,8 @@ TEST_F(WebThreadImplForWorkerSchedulerTest, TestShutdown) {

BLINK_FROM_HERE, WTF::Bind(&MockTask::Run, WTF::Unretained(&task)));

thread_->GetWebTaskRunner()->PostDelayedTask(

BLINK_FROM_HERE,

- WTF::Bind(&MockTask::Run, WTF::Unretained(&delayed_task)), 50ll);

+ WTF::Bind(&MockTask::Run, WTF::Unretained(&delayed_task)),

+ TimeDelta::FromMilliseconds(50));

thread_.reset();

}