Move enums from AXObjectImpl to AXObject

Move enums from AXObjectImpl to AXObject

Move enums from AXObjectImpl to AXObject, and update the #includes that
rely on these. Also remove files with #includes to AXObjectImpl that are
not being used.

BUG=715382
Review-Url: https://codereview.chromium.org/2876453003
Cr-Commit-Position: refs/heads/master@{#473824}
Committed: https://chromium.googlesource.com/chromium/src/+/6bb1f135a2b30ba8a9fa3f7f9df4bc618ff343c6

[sashab, 2017-05-10 06:52:25]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 06:53:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-05-10 06:53:08]

sashab@chromium.org changed reviewers:
+ aboxhall@chromium.org

[sashab, 2017-05-10 06:53:09]

Hi Alice - I've just moved all the enums from AXObjectImpl to AXObject, not the
"minimal subset" (although I think all but a few need to be moved). Wdyt, would
you prefer me to move back the ones that aren't used until we find a file that
needs them?

[aboxhall, 2017-05-10 06:55:28]

On 2017/05/10 06:53:09, sashab wrote:
> Hi Alice - I've just moved all the enums from AXObjectImpl to AXObject, not
the
> "minimal subset" (although I think all but a few need to be moved). Wdyt,
would
> you prefer me to move back the ones that aren't used until we find a file that
> needs them?

Hm - I think yeah, ideally we should keep AXObject as minimal as possible. If
something isn't currently exposed via web/ then it's probably an implementation
detail (or used in devtools).

[commit-bot: I haz the power, 2017-05-10 09:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 09:08:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-10 15:37:56]

+1 - putting it in core/ implies that it's a public API.

On Tue, May 9, 2017 at 11:55 PM <aboxhall@chromium.org> wrote:

> On 2017/05/10 06:53:09, sashab wrote:
> > Hi Alice - I've just moved all the enums from AXObjectImpl to AXObject,
> not
> the
> > "minimal subset" (although I think all but a few need to be moved). Wdyt,
> would
> > you prefer me to move back the ones that aren't used until we find a
> file that
> > needs them?
>
> Hm - I think yeah, ideally we should keep AXObject as minimal as possible.
> If
> something isn't currently exposed via web/ then it's probably an
> implementation
> detail (or used in devtools).
>
> https://codereview.chromium.org/2876453003/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-05-10 15:37:56]

+1 - putting it in core/ implies that it's a public API.

On Tue, May 9, 2017 at 11:55 PM <aboxhall@chromium.org> wrote:

> On 2017/05/10 06:53:09, sashab wrote:
> > Hi Alice - I've just moved all the enums from AXObjectImpl to AXObject,
> not
> the
> > "minimal subset" (although I think all but a few need to be moved). Wdyt,
> would
> > you prefer me to move back the ones that aren't used until we find a
> file that
> > needs them?
>
> Hm - I think yeah, ideally we should keep AXObject as minimal as possible.
> If
> something isn't currently exposed via web/ then it's probably an
> implementation
> detail (or used in devtools).
>
> https://codereview.chromium.org/2876453003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sashab, 2017-05-11 02:52:32]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 02:54:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-05-11 02:55:50]

Thanks alice & dom; ptal now. I've only moved the minimal enums required to get
this to compile :) Might need to move more later, we'll see how it goes.

I kept the relative ordering in case it was important.

Side note: are you interested in changing these to be enum classes instead? I
think there's a general move in blink towards enum classes, and it would let you
forward declare them instead of defining them like this. But I think we should
do that as a side thing, these definitely belong in the public header file.

[commit-bot: I haz the power, 2017-05-11 04:06:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:06:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-05-11 04:12:57]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:13:45]

This CL has an open dependency (Issue 2858493002 Patch 140001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[aboxhall, 2017-05-11 04:24:35]

lgtm

[sashab, 2017-05-16 03:45:09]

sashab@chromium.org changed reviewers:
+ dcheng@chromium.org

[sashab, 2017-05-16 03:45:09]

dcheng ptal at Source/web

[haraken, 2017-05-16 03:48:09]

On 2017/05/16 03:45:09, sashab wrote:
> dcheng ptal at Source/web

LGTM

[dcheng, 2017-05-16 03:59:01]

LGTM 2

[sashab, 2017-05-22 02:54:43]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2017-05-22 02:54:44]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-05-22 02:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, aboxhall@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2876453003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-22 02:54:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 04:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 04:47:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sashab, 2017-05-23 05:05:11]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-05-23 05:05:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 07:07:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495515911615110,
"parent_rev": "273adbb1efcdb09bbbb83a861bca8f07375c5ea7", "commit_rev":
"6bb1f135a2b30ba8a9fa3f7f9df4bc618ff343c6"}

[commit-bot: I haz the power, 2017-05-23 07:07:19]

Description was changed from

==========
Move enums from AXObjectImpl to AXObject

Move enums from AXObjectImpl to AXObject, and update the #includes that
rely on these. Also remove files with #includes to AXObjectImpl that are
not being used.

BUG=715382
==========

to

==========
Move enums from AXObjectImpl to AXObject

Move enums from AXObjectImpl to AXObject, and update the #includes that
rely on these. Also remove files with #includes to AXObjectImpl that are
not being used.

BUG=715382

Review-Url: https://codereview.chromium.org/2876453003
Cr-Commit-Position: refs/heads/master@{#473824}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bb1f135a2b30ba8a9fa3f7f9df4...
==========

[commit-bot: I haz the power, 2017-05-23 07:07:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6bb1f135a2b30ba8a9fa3f7f9df4...