Remove dependency of WebNode.cpp on AXObjectImpl

Remove dependency of WebNode.cpp on AXObjectImpl

Remove dependency of WebNode.cpp on AXObjectImpl, making it depend on
AXObject instead. This involves moving a few static methods to
AXObject.h.

BUG=715382
Review-Url: https://codereview.chromium.org/2872133003
Cr-Commit-Position: refs/heads/master@{#475291}
Committed: https://chromium.googlesource.com/chromium/src/+/ea945f11d9d3d07aa8a8d89782201c4f453d200f

[sashab, 2017-05-10 07:15:34]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 07:16:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-05-10 07:16:54]

sashab@chromium.org changed reviewers:
+ aboxhall@chromium.org

[sashab, 2017-05-10 07:16:54]

PTAL aboxhall - this one should be minimal :)

I can leave more stuff in modules/ if I made
IsInsideFocusableElementOrARIAWidget a virtual non-static method.

Also removed a few private static methods from AXObjectImpl into a private
namespace in the cpp file since they are not used anywhere else.

[commit-bot: I haz the power, 2017-05-10 08:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 08:04:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-05-11 03:12:37]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 03:13:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 05:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 05:34:14]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-05-16 00:22:11]

Ping aboxhall :)

[dmazzoni, 2017-05-16 04:20:45]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-05-16 04:20:45]

lgtm

https://codereview.chromium.org/2872133003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/AXObject.cpp (right):

https://codereview.chromium.org/2872133003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/AXObject.cpp:56: "aria-expanded",        
"aria-haspopup", "aria-multiselectable",
Optional, but could you fix this list while you're at it? I know you
just copied it, but it was ruined by the blink reformat. It should be
one per line. Use "clang-format off" and "clang-format on".

[sashab, 2017-05-22 03:04:51]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 03:04:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-05-22 03:05:16]

sashab@chromium.org changed reviewers:
+ kinuko@chromium.org

[sashab, 2017-05-22 03:05:17]

kinuko ptal at Source/web

https://codereview.chromium.org/2872133003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/AXObject.cpp (right):

https://codereview.chromium.org/2872133003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/AXObject.cpp:56: "aria-expanded",        
"aria-haspopup", "aria-multiselectable",
On 2017/05/16 at 04:20:45, dmazzoni wrote:
> Optional, but could you fix this list while you're at it? I know you
> just copied it, but it was ruined by the blink reformat. It should be
> one per line. Use "clang-format off" and "clang-format on".

Done :) Cool trick

[kinuko, 2017-05-22 03:55:17]

lgtm

[sashab, 2017-05-22 04:04:34]

The CQ bit was unchecked by sashab@chromium.org

[sashab, 2017-05-22 04:04:37]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-05-22 04:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2872133003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-22 04:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 04:04:50]

This CL has an open dependency (Issue 2876453003 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[sashab, 2017-05-23 10:00:02]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-05-23 10:00:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 10:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 10:02:28]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-05-29 03:05:11]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2017-05-29 03:05:13]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-05-29 03:05:14]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2872133003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-29 03:05:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 05:32:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496027113723980,
"parent_rev": "870ec553a786c0f19d6785a4333fa7a6dc2885c0", "commit_rev":
"ea945f11d9d3d07aa8a8d89782201c4f453d200f"}

[commit-bot: I haz the power, 2017-05-29 05:32:31]

Description was changed from

==========
Remove dependency of WebNode.cpp on AXObjectImpl

Remove dependency of WebNode.cpp on AXObjectImpl, making it depend on
AXObject instead. This involves moving a few static methods to
AXObject.h.

BUG=715382
==========

to

==========
Remove dependency of WebNode.cpp on AXObjectImpl

Remove dependency of WebNode.cpp on AXObjectImpl, making it depend on
AXObject instead. This involves moving a few static methods to
AXObject.h.

BUG=715382

Review-Url: https://codereview.chromium.org/2872133003
Cr-Commit-Position: refs/heads/master@{#475291}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea945f11d9d3d07aa8a8d8978220...
==========

[commit-bot: I haz the power, 2017-05-29 05:32:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ea945f11d9d3d07aa8a8d8978220...