Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2876403003: VR: text for audio/video input capture notifications (Closed)

Created:
3 years, 7 months ago by acondor_
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-vr-reviews_chromium.org, srahim+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: text for audio/video input capture notifications - Involved strings where moved from chrome/android to chrome/app for reusability. - Texture proportions and sizes where adjusted according to text length. BUG=722836 Review-Url: https://codereview.chromium.org/2876403003 Cr-Commit-Position: refs/heads/master@{#472676} Committed: https://chromium.googlesource.com/chromium/src/+/76c54665068eef3d5e6893574246bae8fefa736b

Patch Set 1 #

Patch Set 2 : power of 2 ratio #

Patch Set 3 : removing unnecessary comments #

Total comments: 2

Messages

Total messages: 14 (6 generated)
acondor_
mthiesse PTAL, before reaching chrome OWNERS
3 years, 7 months ago (2017-05-15 21:22:24 UTC) #1
acondor_
mthiesse PTAL, before reaching chrome OWNERS
3 years, 7 months ago (2017-05-15 21:28:10 UTC) #3
mthiesse
lgtm https://codereview.chromium.org/2876403003/diff/40001/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc File chrome/browser/android/vr_shell/textures/system_indicator_texture.cc (right): https://codereview.chromium.org/2876403003/diff/40001/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc#newcode62 chrome/browser/android/vr_shell/textures/system_indicator_texture.cc:62: size_.height() + This spacing looks really weird. Did ...
3 years, 7 months ago (2017-05-15 21:44:11 UTC) #4
acondor_
https://codereview.chromium.org/2876403003/diff/40001/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc File chrome/browser/android/vr_shell/textures/system_indicator_texture.cc (right): https://codereview.chromium.org/2876403003/diff/40001/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc#newcode62 chrome/browser/android/vr_shell/textures/system_indicator_texture.cc:62: size_.height() + On 2017/05/15 21:44:11, mthiesse wrote: > This ...
3 years, 7 months ago (2017-05-16 14:18:36 UTC) #7
acondor_
On 2017/05/16 14:18:36, acondor wrote: > https://codereview.chromium.org/2876403003/diff/40001/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc > File chrome/browser/android/vr_shell/textures/system_indicator_texture.cc > (right): > > https://codereview.chromium.org/2876403003/diff/40001/chrome/browser/android/vr_shell/textures/system_indicator_texture.cc#newcode62 ...
3 years, 7 months ago (2017-05-16 14:19:11 UTC) #8
David Trainor- moved to gerrit
lgtm!
3 years, 7 months ago (2017-05-17 22:14:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876403003/40001
3 years, 7 months ago (2017-05-18 03:05:33 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 05:08:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/76c54665068eef3d5e6893574246...

Powered by Google App Engine
This is Rietveld 408576698