Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2876363004: Fix activation issues with SystemTrayBubble. (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix activation issues with SystemTrayBubble. 1) Don't close on deactivation. The bubble is normally not activatable, but after pressing Tab it becomes activatable. It should behave the same in either case, so don't close on deactivation. 2) Explicitly close the info bubble instead of relying on activation changes which may or may not go through. BUG=716397 Review-Url: https://codereview.chromium.org/2867933002 Cr-Original-Commit-Position: refs/heads/master@{#470728} Review-Url: https://codereview.chromium.org/2876363004 . Cr-Commit-Position: refs/branch-heads/3071@{#554} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/3ae3d987dd8fcad652c562bddc3ef66390eb65fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M ash/system/network/network_state_list_detailed_view.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
3 years, 7 months ago (2017-05-15 16:44:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ae3d987dd8fcad652c562bddc3ef66390eb65fc.

Powered by Google App Engine
This is Rietveld 408576698