Fix activation issues with SystemTrayBubble.

Fix activation issues with SystemTrayBubble.

1) Don't close on deactivation. The bubble is normally not
   activatable, but after pressing Tab it becomes activatable.
   It should behave the same in either case, so don't close
   on deactivation.
2) Explicitly close the info bubble instead of relying on
   activation changes which may or may not go through.

BUG=716397
Review-Url: https://codereview.chromium.org/2867933002
Cr-Commit-Position: refs/heads/master@{#470728}
Committed: https://chromium.googlesource.com/chromium/src/+/eadedef7305278a22fca35db34b2831135ff5fb2

[Evan Stade, 2017-05-08 21:50:37]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-05-08 21:50:45]

estade@chromium.org changed reviewers:
+ oshima@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:51:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:51:07]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-05-09 05:12:15]

looks like the info bubble is activatable. Shouldn't it be non activatable?

https://codereview.chromium.org/2867933002/diff/1/ash/system/tray/system_tray.cc
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2867933002/diff/1/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:474: init_params.close_on_deactivate = false;
it's not clear to me why this is necessary. Can you elaborate?

[Evan Stade, 2017-05-09 14:49:53]

On 2017/05/09 05:12:15, oshima wrote:
> looks like the info bubble is activatable. Shouldn't it be non activatable?

AFAIK it has to be activatable for the text inside it (IP addresses) to be
selectable.

https://codereview.chromium.org/2867933002/diff/1/ash/system/tray/system_tray.cc
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2867933002/diff/1/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:474: init_params.close_on_deactivate = false;
On 2017/05/09 05:12:15, oshima wrote:
> it's not clear to me why this is necessary. Can you elaborate?

otherwise, you press tab, then you click the info icon, and it creates a bubble
which takes activation and then the menu closes. Basically, without this, any
widget taking activation will close the menu but only after you've pressed tab.
This makes it so it's the same behavior before and after pressing tab.

[oshima, 2017-05-10 20:47:53]

On 2017/05/09 14:49:53, Evan Stade wrote:
> On 2017/05/09 05:12:15, oshima wrote:
> > looks like the info bubble is activatable. Shouldn't it be non activatable?
> 
> AFAIK it has to be activatable for the text inside it (IP addresses) to be
> selectable.

I see. Changing activation is problematic to ARC++ apps as it can change its
state,
and it'd be better to show in inactive state. I'll file a separate bug.

> 
>
https://codereview.chromium.org/2867933002/diff/1/ash/system/tray/system_tray.cc
> File ash/system/tray/system_tray.cc (right):
> 
>
https://codereview.chromium.org/2867933002/diff/1/ash/system/tray/system_tray...
> ash/system/tray/system_tray.cc:474: init_params.close_on_deactivate = false;
> On 2017/05/09 05:12:15, oshima wrote:
> > it's not clear to me why this is necessary. Can you elaborate?
> 
> otherwise, you press tab, then you click the info icon, and it creates a
bubble
> which takes activation and then the menu closes. Basically, without this, any
> widget taking activation will close the menu but only after you've pressed
tab.
> This makes it so it's the same behavior before and after pressing tab.

Thank you for clarification. lgtm

[Evan Stade, 2017-05-10 21:09:17]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:10:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 22:20:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494450557159710, "parent_rev":
"f949e0e0f1df4914e6bcd45b50e840087b68a46a", "commit_rev":
"eadedef7305278a22fca35db34b2831135ff5fb2"}

[commit-bot: I haz the power, 2017-05-10 22:20:23]

Description was changed from

==========
Fix activation issues with SystemTrayBubble.

1) Don't close on deactivation. The bubble is normally not
   activatable, but after pressing Tab it becomes activatable.
   It should behave the same in either case, so don't close
   on deactivation.
2) Explicitly close the info bubble instead of relying on
   activation changes which may or may not go through.

BUG=716397
==========

to

==========
Fix activation issues with SystemTrayBubble.

1) Don't close on deactivation. The bubble is normally not
   activatable, but after pressing Tab it becomes activatable.
   It should behave the same in either case, so don't close
   on deactivation.
2) Explicitly close the info bubble instead of relying on
   activation changes which may or may not go through.

BUG=716397

Review-Url: https://codereview.chromium.org/2867933002
Cr-Commit-Position: refs/heads/master@{#470728}
Committed:
https://chromium.googlesource.com/chromium/src/+/eadedef7305278a22fca35db34b2...
==========

[commit-bot: I haz the power, 2017-05-10 22:20:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eadedef7305278a22fca35db34b2...