Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2876213002: Use TaskScheduler instead of SequencedWorkerPool in components/feedback. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
afakhry
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of SequencedWorkerPool in components/feedback. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2876213002 Cr-Commit-Position: refs/heads/master@{#473979} Committed: https://chromium.googlesource.com/chromium/src/+/5a26691054acb3098870a6b53185dbdf3a06a92e

Patch Set 1 #

Patch Set 2 : fix-build-errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -29 lines) Patch
M components/feedback/feedback_data_unittest.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M components/feedback/feedback_uploader.h View 3 chunks +1 line, -5 lines 0 comments Download
M components/feedback/feedback_uploader.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M components/feedback/feedback_uploader_chrome.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
fdoray
3 years, 7 months ago (2017-05-12 16:59:03 UTC) #1
fdoray
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for ...
3 years, 7 months ago (2017-05-12 16:59:05 UTC) #3
jochen (gone - plz use gerrit)
please ask a feedback owner to review
3 years, 7 months ago (2017-05-22 11:46:22 UTC) #12
fdoray
PTAL
3 years, 7 months ago (2017-05-23 13:54:39 UTC) #14
afakhry
lgtm
3 years, 7 months ago (2017-05-23 16:04:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876213002/20001
3 years, 7 months ago (2017-05-23 17:12:11 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:13:38 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5a26691054acb3098870a6b53185...

Powered by Google App Engine
This is Rietveld 408576698