Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: components/feedback/feedback_uploader.cc

Issue 2876213002: Use TaskScheduler instead of SequencedWorkerPool in components/feedback. (Closed)
Patch Set: fix-build-errors Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/feedback/feedback_uploader.h ('k') | components/feedback/feedback_uploader_chrome.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/feedback/feedback_uploader.cc
diff --git a/components/feedback/feedback_uploader.cc b/components/feedback/feedback_uploader.cc
index e2781771699eab01385ac5205eb9ef87be6d6596..7f8b79672bac4436f1598259e5f733cd37cfeed4 100644
--- a/components/feedback/feedback_uploader.cc
+++ b/components/feedback/feedback_uploader.cc
@@ -11,7 +11,7 @@
#include "base/files/file_path.h"
#include "base/sequenced_task_runner.h"
#include "base/task_runner_util.h"
-#include "base/threading/sequenced_worker_pool.h"
+#include "base/task_scheduler/post_task.h"
#include "components/feedback/feedback_report.h"
namespace feedback {
@@ -33,22 +33,18 @@ bool FeedbackUploader::ReportsUploadTimeComparator::operator()(
return a->upload_at() > b->upload_at();
}
-FeedbackUploader::FeedbackUploader(const base::FilePath& path,
- base::SequencedWorkerPool* pool)
+FeedbackUploader::FeedbackUploader(const base::FilePath& path)
: report_path_(path.Append(kFeedbackReportPath)),
retry_delay_(base::TimeDelta::FromMinutes(kRetryDelayMinutes)),
- url_(kFeedbackPostUrl),
- pool_(pool) {
+ url_(kFeedbackPostUrl) {
Init();
}
FeedbackUploader::FeedbackUploader(const base::FilePath& path,
- base::SequencedWorkerPool* pool,
const std::string& url)
: report_path_(path.Append(kFeedbackReportPath)),
retry_delay_(base::TimeDelta::FromMinutes(kRetryDelayMinutes)),
- url_(url),
- pool_(pool) {
+ url_(url) {
Init();
}
@@ -92,9 +88,9 @@ void FeedbackUploader::QueueReportWithDelay(const std::string& data,
// Uses a BLOCK_SHUTDOWN file task runner because we really don't want to
// lose reports.
scoped_refptr<base::SequencedTaskRunner> task_runner =
- pool_->GetSequencedTaskRunnerWithShutdownBehavior(
- pool_->GetSequenceToken(),
- base::SequencedWorkerPool::BLOCK_SHUTDOWN);
+ base::CreateSequencedTaskRunnerWithTraits(
+ {base::MayBlock(), base::TaskPriority::BACKGROUND,
+ base::TaskShutdownBehavior::BLOCK_SHUTDOWN});
reports_queue_.push(new FeedbackReport(report_path_,
base::Time::Now() + delay,
« no previous file with comments | « components/feedback/feedback_uploader.h ('k') | components/feedback/feedback_uploader_chrome.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698