Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2876123003: Add ScopedTaskEnvironment in extensions::ModuleSystemTest. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScopedTaskEnvironment in extensions::ModuleSystemTest. This is a prerequisite to migrate v8_platform.cc from base::WorkerPool to base::TaskScheduler. BUG=708584 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2876123003 Cr-Commit-Position: refs/heads/master@{#471286} Committed: https://chromium.googlesource.com/chromium/src/+/897fedad953f7ef4d6d092e3f7ad6d7a34900eea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/renderer/api_test_base.h View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/renderer/module_system_test.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
fdoray
TBR jochen@, who already reviewed this as part of https://codereview.chromium.org/2876523002
3 years, 7 months ago (2017-05-12 12:10:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876123003/1
3 years, 7 months ago (2017-05-12 12:11:02 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 12:40:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/897fedad953f7ef4d6d092e3f7ad...

Powered by Google App Engine
This is Rietveld 408576698