Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2876523002: [reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc. A first version of this CL landed as https://codereview.chromium.org/2610473002/. It was reverted because of hangs in extensions_unittests. These hangs should have been fixed by the addition of a call to TaskScheduler::FlushForTesting() in the destructors of ScopedTaskEnvironment and ScopedAsyncTaskScheduler. The following traits are used: Priority: USER_VISIBLE This task affects UI or responsiveness of future user interactions. It is not an immediate response to a user interaction. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. MayBlock(): The task may block. BUG=659191 Review-Url: https://codereview.chromium.org/2876523002 Cr-Commit-Position: refs/heads/master@{#474346} Committed: https://chromium.googlesource.com/chromium/src/+/b87bcfb8c3b17bbcad020186a94e935e2fd0d162

Patch Set 1 #

Patch Set 2 : fix-test-errors #

Patch Set 3 : self-review #

Patch Set 4 : fix test error #

Patch Set 5 : BLOCK_SHUTDOWN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M gin/v8_platform.cc View 1 2 3 4 3 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 36 (26 generated)
fdoray
Please take a look.
3 years, 7 months ago (2017-05-10 16:55:25 UTC) #10
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-11 08:01:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876523002/30001
3 years, 7 months ago (2017-05-11 23:59:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452602)
3 years, 7 months ago (2017-05-12 02:09:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876523002/50001
3 years, 7 months ago (2017-05-15 13:02:16 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/454397)
3 years, 7 months ago (2017-05-15 14:55:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876523002/50001
3 years, 7 months ago (2017-05-15 16:49:09 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/454606)
3 years, 7 months ago (2017-05-15 18:38:01 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876523002/70001
3 years, 7 months ago (2017-05-24 16:24:57 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 17:49:58 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/b87bcfb8c3b17bbcad020186a94e...

Powered by Google App Engine
This is Rietveld 408576698