|
|
Created:
3 years, 7 months ago by fdoray Modified:
3 years, 7 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc.
A first version of this CL landed as
https://codereview.chromium.org/2610473002/. It was reverted because
of hangs in extensions_unittests. These hangs should have been fixed
by the addition of a call to TaskScheduler::FlushForTesting() in the
destructors of ScopedTaskEnvironment and ScopedAsyncTaskScheduler.
The following traits are used:
Priority: USER_VISIBLE
This task affects UI or responsiveness of future user interactions. It is
not an immediate response to a user interaction.
Shutdown behavior: CONTINUE_ON_SHUTDOWN
Tasks posted with this mode which have not started executing before
shutdown is initiated will never run. Tasks with this mode running at
shutdown will be ignored (the worker will not be joined).
Note: Tasks that were previously posted to base::WorkerPool should
use this shutdown behavior because this is how base::WorkerPool
handles all its tasks.
MayBlock():
The task may block.
BUG=659191
Review-Url: https://codereview.chromium.org/2876523002
Cr-Commit-Position: refs/heads/master@{#474346}
Committed: https://chromium.googlesource.com/chromium/src/+/b87bcfb8c3b17bbcad020186a94e935e2fd0d162
Patch Set 1 #Patch Set 2 : fix-test-errors #Patch Set 3 : self-review #Patch Set 4 : fix test error #Patch Set 5 : BLOCK_SHUTDOWN #Messages
Total messages: 36 (26 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fdoray@chromium.org changed reviewers: + jochen@chromium.org
Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2876523002/#ps50001 (title: "fix test error")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2876523002/#ps70001 (title: "BLOCK_SHUTDOWN")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 70001, "attempt_start_ts": 1495643060155370, "parent_rev": "7de5d92d63eab0410c6e679510ca65941d59587b", "commit_rev": "b87bcfb8c3b17bbcad020186a94e935e2fd0d162"}
Message was sent while issue was closed.
Description was changed from ========== [reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc. A first version of this CL landed as https://codereview.chromium.org/2610473002/. It was reverted because of hangs in extensions_unittests. These hangs should have been fixed by the addition of a call to TaskScheduler::FlushForTesting() in the destructors of ScopedTaskEnvironment and ScopedAsyncTaskScheduler. The following traits are used: Priority: USER_VISIBLE This task affects UI or responsiveness of future user interactions. It is not an immediate response to a user interaction. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. MayBlock(): The task may block. BUG=659191 ========== to ========== [reland] Use TaskScheduler instead of WorkerPool in v8_platform.cc. A first version of this CL landed as https://codereview.chromium.org/2610473002/. It was reverted because of hangs in extensions_unittests. These hangs should have been fixed by the addition of a call to TaskScheduler::FlushForTesting() in the destructors of ScopedTaskEnvironment and ScopedAsyncTaskScheduler. The following traits are used: Priority: USER_VISIBLE This task affects UI or responsiveness of future user interactions. It is not an immediate response to a user interaction. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. MayBlock(): The task may block. BUG=659191 Review-Url: https://codereview.chromium.org/2876523002 Cr-Commit-Position: refs/heads/master@{#474346} Committed: https://chromium.googlesource.com/chromium/src/+/b87bcfb8c3b17bbcad020186a94e... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as https://chromium.googlesource.com/chromium/src/+/b87bcfb8c3b17bbcad020186a94e... |